GHA: Upload AAB to Play Store and Firebase #5176
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @malmstein and the rest of your teammates on |
malmstein
force-pushed
the
feature/david/10-22-gha_upload_aab_to_play_store
branch
4 times, most recently
from
0404cae to
6b23eb4
Compare
malmstein
force-pushed
the
feature/david/10-22-gha_upload_aab_to_play_store
branch
2 times, most recently
from
01aa980 to
34abbf4
Compare
malmstein
force-pushed
the
feature/david/10-22-gha_upload_aab_to_play_store
branch
from
857d523 to
6b90639
Compare
malmstein
changed the title
| git tag -a ${{ steps.generate_version_name.outputs.version }} -m "Create tag ${{ steps.generate_version_name.outputs.version }} for nightly release." | ||
| git push origin ${{ steps.generate_version_name.outputs.version }} | ||
|
|
||
| - name: Upload app bundle as artifact |
There was a problem hiding this comment.
Nit: Name of this step is slightly misleading, we want the apk uploaded as an artifact (not the app bundle).
| with: | ||
| secret: ${{ secrets.UPLOAD_RELEASE_PROPERTIES }} | ||
| fileName: ddg_android_build_upload.properties | ||
| destination-path: $HOME/jenkins_static/com.duckduckgo.mobile.android/ |
There was a problem hiding this comment.
I assume we're still using this particular path to maintain compatibility of our gradle scripts with the existing Jenkins setup?
There was a problem hiding this comment.
Yes. We won’t need this once Jenkins is gone. That being said, devs already have this file structure locally so changing it would involve more work like Onboarding, etc. I’ll leave this change to the very last of the migration,
| jobs: | ||
| create-tag: | ||
| name: Generate and upload nightly bundle to Play Store Internal track | ||
| runs-on: macos-latest |
There was a problem hiding this comment.
Is there a specific reason we need a macOS runner for this workflow? I understand it’s not intended to be executed often, but it still feels wasteful if there are no blockers to using Ubuntu, which is significantly cheaper, IIRC.
There was a problem hiding this comment.
You are right, there’s no need. Moved it all to ubuntu-latest
| workflow_dispatch: | ||
|
|
||
| env: | ||
| ASANA_PAT: ${{ secrets.GH_ASANA_SECRET }} |
There was a problem hiding this comment.
I don't see this being used anywhere in this workflow. Are you planning to generate an asana task on workflow failure?
There was a problem hiding this comment.
Good catch, I missed that step. Adding it now.
malmstein
force-pushed
the
feature/david/10-22-gha_upload_aab_to_play_store
branch
from
6b90639 to
a1f777e
Compare
|
Thanks for the review @lmac012 ! |
malmstein
deleted the
feature/david/10-22-gha_upload_aab_to_play_store
branch
Task/Issue URL: https://app.asana.com/0/42792087274227/1208606985938250/f ### Description This PR enables nightly releases from GHA ### Steps to test this PR Run the workflow
Task/Issue URL: https://app.asana.com/0/42792087274227/1208606985938250/f
Description
This PR enables nightly releases from GHA
Steps to test this PR
Run the workflow