Show on App Launch: Fix option item height #5209
Merged
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minHeight of the RadioButton was stopping the item shrinking to it's minHeight of 48dp when it was eligible to do so
This was the easiest way to allow 48dp for ShowOnAppLaunch and 64dp for VPN countries which we do in the next commit
Now that we can actually shrink to 48dp we need to ensure that the vpn country items match their existing height of 64dp as a result This was the least intrusive way to fix these issues before following up later with additions to OneLineListItem and TwoLineListItem
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
mikescamell
merged commit e4a53b2
into
feature/mike/show-on-app-launch/implementation
6 of 7 checks passed
mikescamell
deleted the
feature/mike/show-on-app-launch/fix-radioitemlist-padding
branch
mikescamell
restored the
feature/mike/show-on-app-launch/fix-radioitemlist-padding
branch
mikescamell
deleted the
feature/mike/show-on-app-launch/fix-radioitemlist-padding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208648215243996/f
Description
Fixes the height of the options on the Show on App Launch screen to 48dp. As a result of this we should do a follow up to add the possibility to our OneLine and TwoLineListItems to allow for a
RadioButtonThis was done with minimal code changes to reduce any effect on the VPN country selection list.
Steps to test this PR
Show on App Launch
VPN Location List
UI changes