ADS: Add disabled state to TextInput #5233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like a mistake. I don't think the error demo should be editable
setting internalInputLayout to disabled disables any buttons, and we can always just set the internalPasswordIcon enabled state regardless
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
malmstein
approved these changes
Nov 4, 2024
mikescamell
deleted the
feature/mike/ads/fix-disabled-text-input-layout
branch
aitorvs
pushed a commit
that referenced
this pull request
Nov 6, 2024
Task/Issue URL: https://app.asana.com/0/488551667048375/1208686387923872/f ### Description - Adds a disabled state for TextInput layout (needed for the Show on App Launch feature) - Adds a hint text demo to the ADS demo screen ### Steps to test this PR - [x] Open ADS screen - [x] Ensure disabled input text match [designs](https://www.figma.com/design/BOHDESHODUXK7wSRNBOHdu/%F0%9F%A4%96-Android-Components?node-id=14783-11394&t=888GVAASRLdwvSuT-4) - [x] Ensure buttons are not clickable when disabled ### UI changes https://github.com/user-attachments/assets/606e65ca-dd09-4b24-a192-e4e53595b112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1208686387923872/f
Description
Steps to test this PR
UI changes
Screen_recording_20241104_140900.mp4