Enable SERP promo for PPro #5239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aitorvs
force-pushed
the
feature/aitor/ppro/serp-promo
branch
from
cc12af3 to
a03a28e
Compare
aitorvs
force-pushed
the
feature/aitor/ppro/serp-promo
branch
3 times, most recently
from
2a32cc6 to
da56b7b
Compare
aitorvs
force-pushed
the
feature/aitor/ppro/serp-promo
branch
3 times, most recently
from
2fb6e4b to
32c03fe
Compare
aitorvs
force-pushed
the
feature/aitor/ppro/serp-promo
branch
from
32c03fe to
eb60a25
Compare
marcosholgado
approved these changes
Nov 7, 2024
| } | ||
| private class CookieManagerWrapperImpl constructor() : CookieManagerWrapper { | ||
|
|
||
| private val cookieManager: CookieManager by lazy { CookieManager.getInstance() } |
There was a problem hiding this comment.
There's already a CookieManagerProvider, perhaps we should use that one to get the instance?
...s/subscriptions-impl/src/main/java/com/duckduckgo/subscriptions/impl/serp_promo/SerpPromo.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1198194956794324/1208264562025856/f
Description
Enable SERP Promo for PPro
Steps to test this PR
Test
privacy_pro_access_tokenSetting cookie privacy_pro_access_token=; for domain .subscriptions.duckduckgo.comlogcat showshttps://subscriptions.duckduckgo.com(this page doesn't exist)privacy_pro_access_tokenis set for.subscriptions.duckduckgo.comwith empty valueprivacy_pro_access_tokenis NOT sethttps://subscriptions.duckduckgo.com(or refresh an already open one)privacy_pro_access_tokenis set for.subscriptions.duckduckgo.comwith token valueprivacy_pro_access_tokenis NOT sethttps://subscriptions.duckduckgo.com(or refresh an already open one)privacy_pro_access_tokenis set for.subscriptions.duckduckgo.comwith empty value