Ask user to swith account when reading code while signed in #5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CDRussell
approved these changes
Nov 15, 2024
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/SyncAccountRepository.kt
Outdated
Show resolved
Hide resolved
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/SyncAccountRepository.kt
Outdated
Show resolved
Hide resolved
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/ui/EnterCodeViewModel.kt
Outdated
Show resolved
Hide resolved
sync/sync-impl/src/test/java/com/duckduckgo/sync/impl/ui/SyncWithAnotherDeviceViewModelTest.kt
Outdated
Show resolved
Hide resolved
cmonfortep
force-pushed
the
feature/cristian/sync/offer_join_account_as_option
branch
from
8837984 to
95ba72c
Compare
This was referenced Nov 15, 2024
cmonfortep
force-pushed
the
feature/cristian/sync/offer_join_account_as_option
branch
4 times, most recently
from
29721ff to
94f20f0
Compare
cmonfortep
force-pushed
the
feature/cristian/sync/offer_join_account_as_option
branch
from
94f20f0 to
043a10a
Compare
…5281) Task/Issue URL: https://app.asana.com/0/1203822806345703/1208755822305613/f ### Description Introduces logic to switch the user account if sync has only 1 device connected. When multiple devices connected, we still ask the user. ### Steps to test this PR _Feature 1_ - [x] Fresh install - [x] Go to Feature flags and enable FF seamlessAccountSwitching - [x] Create a sync account - [x] Save or copy the recovery code - [x] logout - [x] Create a new sync account - [x] Go to "Sync With Another Device", and read or paste the recovery code - [x] Ensure user is automatically switched to the other account _Feature 1_ - [x] Fresh install - [x] Go to Feature flags and enable FF seamlessAccountSwitching - [x] Create a sync account - [x] Save or copy the recovery code - [x] logout - [x] Join this account -> https://app.asana.com/0/1203822806345703/1208795798275452/f - [x] you are connected to an account with more devices - [x] Go to "Sync With Another Device", and read or paste the recovery code from the first account you created - [x] Ensure you are asked to confirm switching accounts ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
cmonfortep
deleted the
feature/cristian/sync/offer_join_account_as_option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208755822305612/f
Description
When a Sync signed in user reads a recovery code, ask them to confirm if they want to switch account.
Includes:
Steps to test this PR
Feature 1
seamlessAccountSwitchingon bothFeature 2 (continuation from previous test)
UI changes