Pixel: Add tab activity stats to a daily pixel #5278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0nko
force-pushed
the
feature/ondrej/tab-activity-stats
branch
from
c4762cf to
04acf5e
Compare
karlenDimla
reviewed
Nov 19, 2024
| import org.mockito.Mockito.mock | ||
| import org.mockito.kotlin.whenever | ||
|
|
||
| class DefaultTabStatsBucketingTest { |
There was a problem hiding this comment.
This doesn’t have to be an Android Test, we can move it to unitTest instead and run it as such.
| } | ||
|
|
||
| @Test | ||
| fun testGetNumberOfOpenTabsExactly1() = runBlocking { |
There was a problem hiding this comment.
Instead of runBlocking, runTest is better to use in tests.
| } | ||
| } | ||
|
|
||
| @ContributesBinding(AppScope::class) |
There was a problem hiding this comment.
Curious q, does it have to be AppScope?
There was a problem hiding this comment.
Not really, it could have been FragmentScope, as well, but since the only dependency here is the TabManager which is also scoped in AppScope, this allows the class to be used from anywhere.
| val inactive2w = viewModelScope.async(dispatchers.io()) { tabStatsBucketing.getTabsActiveTwoWeeksAgo() } | ||
| val inactive3w = viewModelScope.async(dispatchers.io()) { tabStatsBucketing.getTabsActiveMoreThanThreeWeeksAgo() } | ||
|
|
||
| viewModelScope.launch { |
There was a problem hiding this comment.
Would it make sense to run this on io as well, since we have a bunch of await() calls here?
karlenDimla
reviewed
Nov 19, 2024
karlenDimla
approved these changes
Nov 19, 2024
|
@karlenDimla I’ve addressed your comments in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208414748460831/f
Description
This PR adds the following parameters to the
m_tab_manager_clicked_dailypixel:tab_count: The number of open tabstab_active_7d: The number of tabs access within the last 7 daystab_inactive_1w: Tabs not accessed for more than a week, but less than 2 weekstab_inactive_2w: Tabs not accessed for more than 2 weeks, but less than 3 weekstab_inactive_3w: Tabs not accessed for at least 3 weeksAll stats are reported within buckets due to privacy reasons:
A new column was added to the
TabEntity— thelastAccessTime, which is updated every time a tab is activated.Steps to test this PR
DB migration
Pixel firing
m_tab_manager_clicked_dailypixel is fired with all of the parameters mentioned aboveLast access time updates
app.dbdatabasetabstablelastAccessTimewas updated for the access tabs using correct time