Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Only execute nightly if changes made #5289

Merged

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Nov 20, 2024

Task/Issue URL: https://app.asana.com/0/1174433894299346/1208527152986496

Description

Currently we make nightly releases daily, even if there are no new changes in develop.
This PR fixes that, so we only make nightly releases when there are new commits since the last tag.

Steps to test this PR

See task for examples of runs

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

.github/workflows/release_nightly.yml Outdated Show resolved Hide resolved
.github/workflows/release_nightly.yml Outdated Show resolved Hide resolved
@malmstein malmstein marked this pull request as ready for review November 20, 2024 14:11
@malmstein
Copy link
Contributor Author

Thanks @CDRussell !

@malmstein malmstein merged commit 83e8be5 into develop Nov 22, 2024
2 checks passed
@malmstein malmstein deleted the feature/david/11-20-gha_only_execute_nightly_if_changes_made branch November 22, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants