Update Settings design: Add feature flag & new Settings screen #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note we've also duplicated the xml layout and are now referring to it's binding in the Activity I used a new title of "New Settings" for the activity so it's easy to differentiate and notice if you're using the flagged version. I will remove this once we have the new UI for the items and it's more obvious it's the updated version
NotificationsActivity in the next commit
You can see in the viewmodel that I had some issues with the SurveyAvailableNotification 1. The SurveyAvailableNotification needs a notification in the database, otherwise we get a NoElement exception as we call "last()" on the list of surveys when getting them in the intent 2. The intent hits a repo that hits a DAO, that is not a suspend function, so we have to be off the main thread Next we'll add VPN notifications
mikescamell
changed the title
mikescamell
force-pushed
the
feature/mike/update-settings/add-feature-flag
branch
from
16d4729 to
bebaf52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1208785611228225/f
Description
Adds a feature flag and new screen for the new updated Settings screen designs.
For now it's the same layout as before, this is just laying the groundwork for the rest of the implementation.
So you can see that the flag is working, the new Settings screen has a temporary title of "New Settings" which will be removed when the UI changes enough that it's perceivable.
I also added the ability to trigger notifications from dev settings so it's easier to test the ClearData notification route to opening settings.
Steps to test this PR
Opening Settings from the Browser menu
Opening Settings from ADS shortcut
Clear Data Notification
VPN Disabled Notification
Clear Data Notification
New Tab Page
Tab Switcher
Privacy Pro
SpecialUrlDetectorto true and load a web pageUI changes
N/A