Add localStorage exceptions to duckduckgo.com #5338
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
aitorvs
force-pushed
the
feature/aitor/webview/localStorage
branch
from
333721e to
f6bc3a8
Compare
aitorvs
force-pushed
the
feature/aitor/webview/localStorage
branch
from
f6bc3a8 to
38af31a
Compare
There was a problem hiding this comment.
LGTM
Just a note, do you think this could impact the fire button process perf depending on the local storage size? unsure how those webview methods perform depending on size. I don't want to slow you down here, but should we consider adding a kill switch in case we detect an increase on feedback around that?
Testing: I don't have vpn, so I've tested this by changing the excluded domain to ".amazon.com" (instead of .duckduckgo.com) and inspecting the local storage via dev tools. After using fire button, local storage was preserved, so it works.
There was a problem hiding this comment.
I'm taking another look here and there's something I'm missing.
I've been visiting a bunch of sites to see how those webview methods behave, and getOrigins only returns me 1 origin...but from devtools I see all sites stored something inside their localStorage.
The other thing during testing, I've detected a crash in (origin as Origin).origin cast, which was not visible since we do runcatching. java.lang.ClassCastException: java.util.HashMap$Node cannot be cast to android.webkit.WebStorage$Origin
Let's pair on this tomorrow to close those open questions.
aitorvs
force-pushed
the
feature/aitor/webview/localStorage
branch
from
08cd9a8 to
9562bfd
Compare
joshliebe
force-pushed
the
feature/aitor/webview/localStorage
branch
from
9562bfd to
af0cf12
Compare
Task/Issue URL: https://app.asana.com/0/1198194956794324/1208875163490368/f
Description
Steps to test this PR
Test
requirement for all tests: IP address needs to be in the US (use DDG production app or another VPN like Nord)
Get Privacy Pro!...)Get Privacy Pro!...)X)