-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default browser selection overflow menu item #5391
add default browser selection overflow menu item #5391
Conversation
common/common-ui/src/main/res/drawable/ic_default_browser_mobile_color_16.xml
Outdated
Show resolved
Hide resolved
8642896
to
541eba3
Compare
541eba3
to
a2ec247
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don’t need to change the translations, let the service do it for you. Get rid of all the strings changes, and only create new values under donottranslate.xml. Once we are done, we’ll order translations and let the process take its course.
app/src/main/res/drawable/background_default_browser_menu_item.xml
Outdated
Show resolved
Hide resolved
app/src/main/res/drawable/background_default_browser_menu_item.xml
Outdated
Show resolved
Hide resolved
I don't want to change translations, I want to reuse the one we already have in the codebase but I'm adjusting the constant's name to better reflect what it does. Is that a problem? Why would we need to run this through the service again if all the information is already there? If I removed all the strings and added a new one that's not translated, I'd be regressing the functionality that already relies on these translations in other places. |
This reverts commit a2ec247.
Thanks @malmstein for explaining the string management process! I reverted a2ec247 for now to avoid conflicts and I'll re-apply it in a separate translation PR. This is ready for another round. |
876d680
to
b3c64c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @LukasPaczos !
Task/Issue URL: https://app.asana.com/0/72649045549333/1208944504536342/f
Description
Adds an overflow menu item that advertises setting DuckDuckGo as the default browser.
The introduced item is not yet used anywhere and click listeners/handlers will be added in following PRs.
Steps to test this PR
As an example, apply below diff and the item will show up whenever you open the overflow menu.
UI changes