Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify autofill update credential pixel to include backfilled parameter #5392

Draft
wants to merge 1 commit into
base: feature/craig/autofill_increase_ratio_complete_credential_saves
Choose a base branch
from

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Dec 13, 2024

Task/Issue URL: https://app.asana.com/0/1202926619870900/1208976665268815/f

Description

Steps to test this PR

Logcat filter: message~:"Partial save" message~:"Pixel sent: m_autofill_logins_update_password_inline" message~:"Determined that username" message~:"Determined that username”

Simulating a multi-step login form

  • Ensure no passwords currently saved (or none for autofill.me at least)
  • Visit https://autofill.me/form/login-simple
  • Enter username test
  • Leave password blank
  • Hit Login button
  • Now clear the username
  • Enter password (>=4 characters)
  • Hit Login button
  • Save password when prompted, then go view it in the Password Management view (e.g., tap on View in snackbar)
  • Verify it has username=test and password matches what you provided (i.e., the username was backfilled because the partial form submission’s username was later applied to the final form submission which didn’t have the username)
  • [ ]

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves branch from 969ed0e to b196a10 Compare December 17, 2024 17:40
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves_pixels branch from 0223949 to d147d82 Compare December 17, 2024 17:41
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves branch from b196a10 to 5580d9f Compare December 18, 2024 17:02
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves_pixels branch 3 times, most recently from 276377c to beb9d61 Compare December 18, 2024 17:06
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves branch from 5580d9f to cfea135 Compare December 18, 2024 17:53
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves_pixels branch from beb9d61 to 1113c2c Compare December 18, 2024 17:53
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves branch from cfea135 to 469dfbf Compare December 18, 2024 18:06
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves_pixels branch from 1113c2c to a6e3dd9 Compare December 18, 2024 18:06
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves branch from 469dfbf to b8badc8 Compare December 19, 2024 10:14
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves_pixels branch from a6e3dd9 to 3b38a15 Compare December 19, 2024 10:14
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves branch from b8badc8 to a36b674 Compare December 19, 2024 10:17
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves_pixels branch from 3b38a15 to ca2147f Compare December 19, 2024 10:17
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves branch from a36b674 to 16e1970 Compare December 20, 2024 16:42
@CDRussell CDRussell force-pushed the feature/craig/autofill_increase_ratio_complete_credential_saves_pixels branch from ca2147f to 0264894 Compare December 20, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant