Code

Tab swiping: Pixels#5400

Code

Merged

0nko merged 105 commits intofeature/ondrej/swiping-tabsduckduckgo/Android:feature/ondrej/swiping-tabsfrom feature/ondrej/swiping-tabs-pixelsduckduckgo/Android:feature/ondrej/swiping-tabs-pixelsCopy head branch name to clipboardDec 20, 2024

+20-1

Commits

Commits on Nov 11, 2024

• Move the existing tab management functionality to a separate class

  0nko

  committed
  df8b2f6

• Move the tab-related calls to TabManager

  0nko

  committed
  3579d31

• Remove unused code

  0nko

  committed
  eb1c607

• Clean up code

  0nko

  committed
  b29d761

• Add onCleanup function

  0nko

  committed
  d9f13c4

• Extract a TabManager interface

  0nko

  committed
  a6b8d7e

• Use an injected TabManager for tab-related operations

  0nko

  committed
  c2b0cd2

• Fix ktlint issues

  0nko

  committed
  d865d18

• Rename function for easier readability

  0nko

  committed
  23cf2d4

• Inject the TabManager interface instead of the implementation class

  0nko

  committed
  a0dc5cc

• Remove unnecessary null checks

  0nko

  committed
  16af89e

• Add view pager to the layout and create an adapter

  0nko

  committed
  d3454d5

• Initialize the adapter in the tab manager

  0nko

  committed
  a323814

• Add method to get tab by ID

  0nko

  committed
  c443b8d

• Optimize the fragment initialization for the view pager use case

  0nko

  committed
  57016fd

• Add methods to observe the onboarding status

  0nko

  committed
  84ba944

Commits on Nov 12, 2024

• Fix the new tab creation

  0nko

  committed
  d1f1413

• Handle the new tab creation using a message from another tab

  0nko

  committed
  9b665a0

Commits on Nov 17, 2024

• Initialize the tab fragment when it becomes active

  0nko

  committed
  b581903

Commits on Nov 18, 2024

• Rename the tab manager impelemntation

  0nko

  committed
  9e4c066

• Disable tab deletion when there is just one

  0nko

  committed
  1402075

Commits on Nov 20, 2024

• Switch to the existing empty tab instead of opening a new one

  0nko

  committed
  a311686

Commits on Nov 21, 2024

• Update tab callbacks

  0nko

  committed
  1635f4d

• Change the onActivityCreated to onViewCreated

  0nko

  committed
  e92daba

• Disable viewpager swiping over the webview

  0nko

  committed
  c5af1d0

• Check if the tab has changed before calling the callback

  0nko

  committed
  2b4abae

• Clean up

  0nko

  committed
  cbf1df2

• Use an existing empty tab instead of opening a new one

  0nko

  committed
  dedd69a

• Use a flow to access the currently selected tab

  0nko

  committed
  24c8fa8

• Use LiveData instead of Flows

  0nko

  committed
  7dc5e96

• Merge branch 'develop' into feature/ondrej/multi-tab-refactor

  Show description for 5eaa361
  0nko

  committed
  5eaa361

• Fix the merge

  0nko

  committed
  f9e9255

• Merge branch 'feature/ondrej/multi-tab-refactor' into feature/ondrej/swiping-tabs-ui

  0nko

  committed
  d3ceaea

Commits on Nov 25, 2024

• Make selected tab flow nullable

  0nko

  committed
  ca31c56

• Fix the tab update mechanism and only use 1 tab when swiping disabled

  0nko

  committed
  f186a6c

Commits on Nov 26, 2024

• Refactor the tab switching mechanism

  0nko

  committed
  d780577

• Merge branch 'feature/ondrej/swiping-tabs' into feature/ondrej/swiping-tabs-ui

  Show description for f7fdff1
  0nko

  committed
  f7fdff1

• Cache the feature flag to avoid inconsistent behavior

  0nko

  committed
  6ee26d6

Commits on Nov 27, 2024

• Merge branch 'feature/ondrej/tab-swiping-ff-cache' into feature/ondrej/swiping-tabs-ui

  0nko

  committed
  da06b78

• Fix the merge

  0nko

  committed
  fda2287

• Enable the tab swiping internally

  0nko

  committed
  dcef654

• Optimize imports

  0nko

  committed
  b5b0df7

• Clean up

  0nko

  committed
  dbe281c

• Fix unit tests

  0nko

  committed
  bb80ee3

• Fix the logic for new tab creation on long press

  0nko

  committed
  181dbb1

• Fix the uni tests

  0nko

  committed
  75535ba

• Don't use smooth scroll when changing tabs

  0nko

  committed
  edc9e63

Commits on Dec 2, 2024

• Don't hide empty tab list

  0nko

  committed
  17111cc

Commits on Dec 3, 2024

• Move the offscreen tab change call

  0nko

  committed
  cb48549

Commits on Dec 4, 2024

• Initialize the cached swiping tab feature value lazily

  0nko

  committed
  7e5f61d

• Merge branch 'feature/ondrej/swiping-tabs' into feature/ondrej/tab-swiping-ff-cache

  0nko

  committed
  2969531

• Merge branch 'feature/ondrej/swiping-tabs' into feature/ondrej/tab-swiping-ff-cache

  0nko

  committed
  4708bc4

• Merge branch 'feature/ondrej/tab-swiping-ff-cache' into feature/ondrej/swiping-tabs-ui

  Show description for c8d0887
  0nko

  committed
  c8d0887

Commits on Dec 7, 2024

• Fix formatting

  0nko

  committed
  3e9cbe5

• Simplify the tab selection change in the view pager

  0nko

  committed
  9444520

• Update the default off-screen page limit constant

  0nko

  committed
  559b676

Commits on Dec 9, 2024

• Remove unused code

  0nko

  committed
  3b7937d

Commits on Dec 10, 2024

• Don't animate parent hierachy in viewpager

  0nko

  committed
  18127cc

• Add a copy of FragmentStateAdapter with modifications to how fragments are recycled

  0nko

  committed
  cda71da

• Limit the number of active tabs to 20 to avoid the TransactionTooLargeException

  0nko

  committed
  e93708d

Commits on Dec 11, 2024

• Move the tab adapter into a separate package

  0nko

  committed
  6004d01

• Remove the initialization checks that are not necessary anymore

  0nko

  committed
  6e29210

• Convert the FragmentViewHolder to Kotlin

  0nko

  committed
  5464b53

• Update the javadoc of FragmentStateAdapter

  0nko

  committed
  e298932

• Merge branch 'feature/ondrej/swiping-tabs' into feature/ondrej/tab-swiping-ff-cache

  0nko

  committed
  bf64d27

• Merge branch 'feature/ondrej/tab-swiping-ff-cache' into feature/ondrej/swiping-tabs-ui

  0nko

  committed
  89c48d0

Commits on Dec 16, 2024

• Fix a crash when changing omnibar position

  0nko

  committed
  2193349

• Fix a possible premature drawing issue

  0nko

  committed
  e91bbf1

• Replace the LiveData with a Flow

  0nko

  committed
  0402a91

• Save the viewpager state to prevent weird behavior when changing omnibar position

  0nko

  committed
  eaf8782

• Merge branch 'feature/ondrej/swiping-tabs' into feature/ondrej/tab-swiping-ff-cache

  0nko

  committed
  a1081fd

• Merge branch 'feature/ondrej/tab-swiping-ff-cache' into feature/ondrej/swiping-tabs-ui

  0nko

  committed
  e3b4881

• Ignore the FragmentStateAdapter file to fix the CI build

  0nko

  committed
  614ee83

• Disable tab swiping with autocomplete list

  0nko

  committed
  504777e

• Fix a bug when the viewpager doesn't snap to the page

  0nko

  committed
  be40e2f

• Disable state saving because it causes a TransactionTooLargeException

  0nko

  committed
  b55cca8

Commits on Dec 17, 2024

• Clear all fragments when recreating the activity to prevent them from reloading

  0nko

  committed
  b44bc2d

• Don't delay resuming the webview unless necessary

  0nko

  committed
  ca177e6

• Remove the occasional jump when creating a new tab

  0nko

  committed
  394a031

• Debounce the selected tab to prevent quick tab updates

  0nko

  committed
  7bc90bd

• Add tab swiping pixel tracking

  0nko

  committed
  b921f1f

• Move the pixel tracking to the ViewModel to ease testing

  0nko

  committed
  48de585

• Add a unit test for the pixels

  0nko

  committed
  d012a36

• Fix a bug when the selected tab is not shown

  0nko

  committed
  a236cee

• Switch to an existing tab if a bookmark's URL is already open or open a new tab

  0nko

  committed
  3bd16ee

• Update the open bookmark tests

  0nko

  committed
  d9dfb89

Commits on Dec 18, 2024

• Remove the tabManager injection in the tab fragment because it can be used in custom tab

  0nko

  committed
  a231133

• Call the tab functionality via TabManager

  0nko

  committed
  df93a54

• Optimize Room flows

  0nko

  committed
  b5f226f

• Allow deleting the last tab

  0nko

  committed
  c267967

• Clean up

  0nko

  committed
  17c5e29

• Hide the new tab request behind a feature flag

  0nko

  committed
  455ba61

• Move the onTabSelected callback to the TabManager

  0nko

  committed
  9bd8f1d

• Request new tab within the TabManager

  0nko

  committed
  5302daa

• Move the remaining tab-related methods to the TabManager

  0nko

  committed
  49ff2c0

• Make the ViewModel private

  0nko

  committed
  06bab9e

• Add all the missing feature flag checks

  0nko

  committed
  a0352f8

• Clean up

  0nko

  committed
  f623148

• Avoid calling runBlocking when getting current tab ID

  0nko

  committed
  d6909c8

• Fix the unit tests

  0nko

  committed
  3872406

• Merge branch 'feature/ondrej/swiping-tabs' into feature/ondrej/tab-swiping-ff-cache

  0nko

  committed
  16acc60

• Merge branch 'feature/ondrej/tab-swiping-ff-cache' into feature/ondrej/swiping-tabs-ui

  0nko

  committed
  4a723ba

• Merge branch 'feature/ondrej/swiping-tabs-ui' into feature/ondrej/swiping-tabs-pixels

  Show description for 7b3e155
  0nko

  committed
  7b3e155

Commits on Dec 20, 2024

• Merge branch 'feature/ondrej/swiping-tabs' into feature/ondrej/swiping-tabs-pixels

  Show description for f5058fd
  0nko

  committed
  f5058fd

• Fix merge mistake

  0nko

  committed
  791bafb