AppTP: Flaky whenLocalDateNowThenReturnWeeklyCohort test #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikiki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200905986587319/1209058892339948/f
Description
Fixed flaky test.
whenLocalDateNowThenReturnWeeklyCohortshould assert on week based year and not the year directly as this makes the expected value to be incorrect in edge-cases where the date is a date in a year and falls into a previous year week. I.e 2025-01-01.Steps to test this PR
Note: PR Unit tests should pass as it was submitted the same day that caused the failure (2024-01-30).
whenLocalDateNowThenReturnWeeklyCohortdate to beLocalDate.of(2024, 1, 30)NO UI changes