Prevent resetting the VPN environment. (#738)

Required:

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206899355242110/f
iOS PR: duckduckgo/iOS#2623
macOS PR: duckduckgo/macos-browser#2477
What kind of version bump will this require?: Patch

Description:

This PR prevents the app from resetting the environment when uninstalling the VPN.

The environment is a debug-only setting, and uninstalling the browser is common to do when testing internally, so we should keep it persisted.

Sources/NetworkProtection/NetworkProtectionDeviceManager.swift

@@ -319,7 +319,7 @@ public actor NetworkProtectionDeviceManager: NetworkProtectionDeviceManagement {
                                                dns: [DNSServer(address: server.serverInfo.internalIP)],
                                                isKillSwitchEnabled: isKillSwitchEnabled)
 
-        return TunnelConfiguration(name: "Network Protection", interface: interface, peers: [peerConfiguration])
+        return TunnelConfiguration(name: "DuckDuckGo VPN", interface: interface, peers: [peerConfiguration])
     }
 
     func peerConfiguration(serverPublicKey: PublicKey, serverEndpoint: Endpoint) -> PeerConfiguration {

Sources/NetworkProtection/Settings/VPNSettings.swift

@@ -194,7 +194,6 @@ public final class VPNSettings {
         defaults.resetNetworkProtectionSettingNotifyStatusChanges()
         defaults.resetNetworkProtectionSettingRegistrationKeyValidity()
         defaults.resetNetworkProtectionSettingSelectedServer()
-        defaults.resetNetworkProtectionSettingSelectedEnvironment()
         defaults.resetNetworkProtectionSettingShowInMenuBar()
     }