Skip to content

Commit

Permalink
returns empty certificate array when no certificate (#750)
Browse files Browse the repository at this point in the history
* returns empty certificate array when no certificate

* css dependency

* remove pointing at new CSS branch

* point at ssl test branch

* point to dashboard branch

* add sslcertificate privacy feature

* update privacy dashboard dependency

* update CSS dependecy
  • Loading branch information
SabrinaTardio authored Apr 12, 2024
1 parent f6d789b commit b0749d2
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 7 deletions.
8 changes: 4 additions & 4 deletions Package.resolved
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/content-scope-scripts",
"state" : {
"revision" : "62d5dc3d02f6a8347dc5f0b52162a0107d38b74c",
"version" : "5.8.0"
"revision" : "1bb3bc5eb565735051f342a87b5405d4374876c7",
"version" : "5.12.0"
}
},
{
Expand All @@ -50,8 +50,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/privacy-dashboard",
"state" : {
"revision" : "620921fea14569eb00745cb5a44890d5890d99ec",
"version" : "3.4.0"
"revision" : "14b13d0c3db38f471ce4ba1ecb502ee1986c84d7",
"version" : "3.5.0"
}
},
{
Expand Down
4 changes: 2 additions & 2 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ let package = Package(
.package(url: "https://github.com/duckduckgo/TrackerRadarKit", exact: "1.2.2"),
.package(url: "https://github.com/duckduckgo/sync_crypto", exact: "0.2.0"),
.package(url: "https://github.com/gumob/PunycodeSwift.git", exact: "2.1.0"),
.package(url: "https://github.com/duckduckgo/privacy-dashboard", exact: "3.4.0"),
.package(url: "https://github.com/duckduckgo/content-scope-scripts", exact: "5.8.0"),
.package(url: "https://github.com/duckduckgo/privacy-dashboard", exact: "3.5.0"),
.package(url: "https://github.com/duckduckgo/content-scope-scripts", exact: "5.12.0"),
.package(url: "https://github.com/httpswift/swifter.git", exact: "1.5.0"),
.package(url: "https://github.com/duckduckgo/bloom_cpp.git", exact: "3.0.0"),
.package(url: "https://github.com/duckduckgo/wireguard-apple", exact: "1.1.3"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public enum PrivacyFeature: String {
case history
case performanceMetrics
case privacyPro
case sslCertificates
}

/// An abstraction to be implemented by any "subfeature" of a given `PrivacyConfiguration` feature.
Expand Down Expand Up @@ -125,3 +126,8 @@ public enum PrivacyProSubfeature: String, Equatable, PrivacySubfeature {
case isLaunchedOverride
case isLaunchedOverrideStripe
}

public enum sslCertificatesSubfeature: String, PrivacySubfeature {
public var parent: PrivacyFeature { .sslCertificates }
case allowBypass
}
3 changes: 2 additions & 1 deletion Sources/PrivacyDashboard/ServerTrustViewModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ public struct ServerTrustViewModel: Encodable {

public init?(serverTrust: SecTrust?) {
guard let serverTrust = serverTrust else {
return nil
self.secCertificateViewModels = []
return
}

let secTrust = serverTrust
Expand Down

0 comments on commit b0749d2

Please sign in to comment.