Update supported Xcode version to 16.0 #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
force-pushed
the
dominik/xcode-16
branch
from
456503a
to
2e17f70
Compare
ayoy
force-pushed
the
dominik/xcode-16
branch
from
6c9b231
to
28c03b8
Compare
ayoy
force-pushed
the
dominik/xcode-16
branch
from
8891bdf
to
86f6b4c
Compare
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
* main: Use cookie to share subscription access token on DDG domains (#1034) update css dependency (#1037) Email parsing improved (#1016) Add NTP Search Bar feature flag (#1023) VPN logs fix (#1030) Add AI Chat feature flag (#1031) fix breakByRaisingSigInt mistakenly called when run w/o debugger (#1029)
* main: Validate VPN errors before re-throwing them (#1054) Allowing users to delete suggestions (#1027) Revert "Bump github.com/1024jp/gzipswift from 6.0.1 to 6.1.0" (#1055) Bump github.com/duckduckgo/privacy-dashboard from 5.3.0 to 7.1.1 (#1046) Bump github.com/duckduckgo/sync_crypto from 0.2.0 to 0.3.0 (#1048) Bump github.com/1024jp/gzipswift from 6.0.1 to 6.1.0 (#1050)
These changes should be cleared with Thom first, and are unrelated to Xcode 16.
This reverts commit 596ed27.
samsymons
reviewed
Nov 12, 2024
Comment on lines
-414
to
-417
| resources: [ | ||
| .copy("hashPrefixes.json"), | ||
| .copy("filterSet.json") | ||
| ], |
There was a problem hiding this comment.
I checked this with @not-a-rootkit, this change is trying to copy files which don't exist on-disk which causes problems with Xcode 16 - we can safely remove them.
There was a problem hiding this comment.
Thanks, these warnings were becoming annoying :)
samsymons
reviewed
Nov 12, 2024
Comment on lines
+182
to
+188
| let configDataExpectation = XCTNSPredicateExpectation(predicate: NSPredicate { _, _ in | ||
| return managerA.dependencyProvider.privacyConfigData == configData | ||
| }, object: .none) | ||
|
|
||
| let configEtagExpectation = XCTNSPredicateExpectation(predicate: NSPredicate { _, _ in | ||
| return managerA.dependencyProvider.privacyConfigEtag == HTTPURLResponse.testEtag | ||
| }, object: .none) |
There was a problem hiding this comment.
This test has a race condition related to file coordinators that has since become more obvious with Xcode 16. This change to wait for the expected value has fixed it 100% of the time for me, even after hundreds of runs.
* main: implement experiment manager (#1066)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1203301625297703/1208329354262556/f
iOS PR: duckduckgo/iOS#3377
macOS PR: duckduckgo/macos-browser#3320
What kind of version bump will this require?: Patch
Description:
This change updates CI workflows to use Xcode 16 and run on macOS 15
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template