Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update autofill to 16.1.0 #1138

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Update autofill to 16.1.0 #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26d7f50
Update autofill to 16.1.0
dbajpeyi Dec 18, 2024
71e8d00
Pass partial_form_saves feature flag to JS layer
amddg44 Jan 7, 2025
868ca8f
Merge remote-tracking branch 'origin/main' into update-autofill-16.1.0
amddg44 Jan 7, 2025
a23a1f1
Update mocks
amddg44 Jan 7, 2025
62c6e9b
Update test
amddg44 Jan 7, 2025
800fabc
Merge remote-tracking branch 'origin/main' into update-autofill-16.1.0
amddg44 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.resolved
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/duckduckgo-autofill.git",
"state" : {
"revision" : "88982a3802ac504e2f1a118a73bfdf2d8f4a7735",
"version" : "16.0.0"
"revision" : "47c26dc32b94cdbcef3e6157497147917678c25c",
"version" : "16.1.0"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ let package = Package(
.library(name: "PrivacyStats", targets: ["PrivacyStats"]),
],
dependencies: [
.package(url: "https://github.com/duckduckgo/duckduckgo-autofill.git", exact: "16.0.0"),
.package(url: "https://github.com/duckduckgo/duckduckgo-autofill.git", exact: "16.1.0"),
.package(url: "https://github.com/duckduckgo/GRDB.swift.git", exact: "2.4.2"),
.package(url: "https://github.com/duckduckgo/TrackerRadarKit", exact: "3.0.0"),
.package(url: "https://github.com/duckduckgo/sync_crypto", exact: "0.3.0"),
Expand Down
7 changes: 6 additions & 1 deletion Sources/BrowserServicesKit/ContentScopeScript/ContentScopeUserScript.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ public struct ContentScopeFeatureToggles: Encodable {

public let unknownUsernameCategorization: Bool

public let partialFormSaves: Bool

// Explicitly defined memberwise init only so it can be public
public init(emailProtection: Bool,
emailProtectionIncontextSignup: Bool,
Expand All @@ -92,7 +94,8 @@ public struct ContentScopeFeatureToggles: Encodable {
passwordGeneration: Bool,
inlineIconCredentials: Bool,
thirdPartyCredentialsProvider: Bool,
unknownUsernameCategorization: Bool) {
unknownUsernameCategorization: Bool,
partialFormSaves: Bool) {

self.emailProtection = emailProtection
self.emailProtectionIncontextSignup = emailProtectionIncontextSignup
Expand All @@ -104,6 +107,7 @@ public struct ContentScopeFeatureToggles: Encodable {
self.inlineIconCredentials = inlineIconCredentials
self.thirdPartyCredentialsProvider = thirdPartyCredentialsProvider
self.unknownUsernameCategorization = unknownUsernameCategorization
self.partialFormSaves = partialFormSaves
}

enum CodingKeys: String, CodingKey {
Expand All @@ -121,6 +125,7 @@ public struct ContentScopeFeatureToggles: Encodable {
case inlineIconCredentials = "inlineIcon_credentials"
case thirdPartyCredentialsProvider = "third_party_credentials_provider"
case unknownUsernameCategorization = "unknown_username_categorization"
case partialFormSaves = "partial_form_saves"
}
}

Expand Down
3 changes: 2 additions & 1 deletion Tests/BrowserServicesKitTests/ContentScopeScriptTests/ContentScopePropertiesMocks.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ extension ContentScopeFeatureToggles {
passwordGeneration: true,
inlineIconCredentials: true,
thirdPartyCredentialsProvider: false,
unknownUsernameCategorization: true)
unknownUsernameCategorization: true,
partialFormSaves: true)
}
3 changes: 2 additions & 1 deletion Tests/BrowserServicesKitTests/Fingerprinting/FingerprintingReferenceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ final class FingerprintingReferenceTests: XCTestCase {
passwordGeneration: false,
inlineIconCredentials: false,
thirdPartyCredentialsProvider: false,
unknownUsernameCategorization: false)
unknownUsernameCategorization: false,
partialFormSaves: false)

let contentScopeProperties = ContentScopeProperties(gpcEnabled: false,
sessionKey: UUID().uuidString,
Expand Down
Loading