This repository has been archived by the owner on Feb 24, 2025. It is now read-only.
Handling ReportBrokenSiteShown message #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgurgel
commented
Jan 16, 2025
| @@ -368,10 +368,13 @@ extension PrivacyDashboardController: PrivacyDashboardUserScriptDelegate { | |||
| } | |||
|
|
|||
| func userScriptDidRequestShowReportBrokenSite(_ userScript: PrivacyDashboardUserScript) { | |||
There was a problem hiding this comment.
This is a legacy message that will isn’t currently being fired and is likely to be removed in the future.
This was referenced Jan 17, 2025
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
c77e36e to
13ccadd
Compare
mgurgel
force-pushed
the
mgurgel/improved-breakage-form-pixel
branch
from
6a2da92 to
f85a419
Compare
afterxleep
approved these changes
Jan 17, 2025
mgurgel
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jan 17, 2025
Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f **Description**: Set ups Privacy Dashboard EventMapping as to align with iOS. Each mapped event fires a pixel when invoked by the Privacy Dashboard. See duckduckgo/BrowserServicesKit#1167 Note: not all events are currently used by the Dashboard. Some are being deprecated, which is why they might not be fired at all even though they still exist in the mapping. **Steps to test this PR**: 1. Invoke the breakage form in the two possible ways: Open the Privacy Dashboard and click on "Report a problem with this site" Open the app menu ••• and click on "Report Broken Site” (iOS) 2. Confirm that the pixel `m_report-broken-site_shown` was fired 3. Submit a report 4. Confirm that the pixels `epbf_macos_desktop` and `m_report-broken-site_sent` were fired
mgurgel
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jan 17, 2025
<!-- Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, although assigning a GitHub reviewer and the items in bold are required.⚠️ If you're an external contributor, please file an issue first before working on a PR, as we can't guarantee that we will accept your changes if they haven't been discussed ahead of time. Thanks! --> Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f **Description**: Removes automatic firing of `BrokenSiteReportShown` pixel to align with macOS. The firing of that pixel is now actively requested by the Privacy Dashboard (see duckduckgo/BrowserServicesKit#1167) This PR contains a fix for on #3802 which is why it is stacked on it. Please let me know if this is not the best way to have this code reviewed. **Steps to test this PR**: 1. Invoke the breakage form in the two possible ways: Open the Privacy Dashboard and click on "Report a problem with this site" Open the app menu ••• and click on "Report Broken Site” (iOS) 2. Confirm that the pixel `m_report-broken-site_shown` was fired 3. Submit a report 4. Confirm that the pixels `epbf` and `m_report-broken-site_sent` were fired **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Copy Testing**: * [ ] Use of correct apostrophes in new copy, ie `’` rather than `’` **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad **OS Testing**: * [ ] iOS 15 * [ ] iOS 16 * [ ] iOS 17 **Theme Testing**: * [ ] Light theme * [ ] Dark theme — ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Co-authored-by: Jacek Łyp <[email protected]>
mgurgel
added a commit
that referenced
this pull request
Jan 20, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f iOS PR: duckduckgo/iOS#3822 macOS PR: duckduckgo/macos-browser#3744 What kind of version bump will this require?: Minor **Description**: Implements Privacy Dashboard message `ReportBrokenSiteShown` which will trigger a pixel on macOS and iOS This PR contains a fix for #1160 which is why it is stacked on it. Please let me know if this is not the best way to have this code reviewed. **Steps to test this PR**: 1. Invoke the breakage form in the two possible ways: Open the Privacy Dashboard and click on "Report a problem with this site" Open the app menu ••• and click on "Report Broken Site” (iOS) 2. Confirm that the pixel `m_report-broken-site_shown` was fired 3. Submit a report 4. Confirm that the pixels `epbf` (iOS) / `epbf_macos_desktop` (macOS) and `m_report-broken-site_sent` were fired <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
mgurgel
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jan 20, 2025
Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f **Description**: Set ups Privacy Dashboard EventMapping as to align with iOS. Each mapped event fires a pixel when invoked by the Privacy Dashboard. See duckduckgo/BrowserServicesKit#1167 Note: not all events are currently used by the Dashboard. Some are being deprecated, which is why they might not be fired at all even though they still exist in the mapping. **Steps to test this PR**: 1. Invoke the breakage form in the two possible ways: Open the Privacy Dashboard and click on "Report a problem with this site" Open the app menu ••• and click on "Report Broken Site” (iOS) 2. Confirm that the pixel `m_report-broken-site_shown` was fired 3. Submit a report 4. Confirm that the pixels `epbf_macos_desktop` and `m_report-broken-site_sent` were fired
mgurgel
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jan 20, 2025
<!-- Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, although assigning a GitHub reviewer and the items in bold are required.⚠️ If you're an external contributor, please file an issue first before working on a PR, as we can't guarantee that we will accept your changes if they haven't been discussed ahead of time. Thanks! --> Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f **Description**: Removes automatic firing of `BrokenSiteReportShown` pixel to align with macOS. The firing of that pixel is now actively requested by the Privacy Dashboard (see duckduckgo/BrowserServicesKit#1167) This PR contains a fix for on #3802 which is why it is stacked on it. Please let me know if this is not the best way to have this code reviewed. **Steps to test this PR**: 1. Invoke the breakage form in the two possible ways: Open the Privacy Dashboard and click on "Report a problem with this site" Open the app menu ••• and click on "Report Broken Site” (iOS) 2. Confirm that the pixel `m_report-broken-site_shown` was fired 3. Submit a report 4. Confirm that the pixels `epbf` and `m_report-broken-site_sent` were fired **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Copy Testing**: * [ ] Use of correct apostrophes in new copy, ie `’` rather than `’` **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad **OS Testing**: * [ ] iOS 15 * [ ] iOS 16 * [ ] iOS 17 **Theme Testing**: * [ ] Light theme * [ ] Dark theme — [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Co-authored-by: Jacek Łyp <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required:
Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f
iOS PR: duckduckgo/iOS#3822
macOS PR: duckduckgo/macos-browser#3744
What kind of version bump will this require?: Minor
Description:
Implements Privacy Dashboard message
ReportBrokenSiteShownwhich will trigger a pixel on macOS and iOSThis PR contains a fix for #1160 which is why it is stacked on it. Please let me know if this is not the best way to have this code reviewed.
Steps to test this PR:
Invoke the breakage form in the two possible ways:
Open the Privacy Dashboard and click on "Report a problem with this site"
Open the app menu ••• and click on "Report Broken Site” (iOS)
Confirm that the pixel
m_report-broken-site_shownwas firedSubmit a report
Confirm that the pixels
epbf(iOS) /epbf_macos_desktop(macOS) andm_report-broken-site_sentwere firedOS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template