String NSRange extension

[mallexxx]

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1177771139624306/1205421610519119/f
iOS PR: duckduckgo/iOS#1989
macOS PR: duckduckgo/macos-browser#1610
What kind of version bump will this require?: Minor

Optional:

• refactored String NSRange helpers to use designated functions

Description:

• see macOS PR

[tomasstrba]

LGTM! ✅

Adding few unit tests would help here, but not a blocker.

[mallexxx]

I don‘t see a need or for what to add tests for the changes of this PR, no logics were added.

[tomasstrba]

As an example, I see new implementations of properties and methods in StringProtocol. Perfect candidates for unit tests.

public extension StringProtocol {

    // MARK: NSRange

    var fullRange: NSRange {
        NSRange(startIndex..<endIndex, in: self)
    }

    func length() -> Int {
        self.fullRange.length
    }

    subscript (_ range: NSRange) -> Self.SubSequence? {
        Range(range, in: self).map { self[$0] }
    }