Switch Sync environment to production #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaresiak
reviewed
Sep 14, 2023
Sources/DDGSync/DDGSync.swift
Outdated
| try? updateAccount(nil) | ||
| dependencies.updateServerEnvironment(serverEnvironment) | ||
| authState = .initializing | ||
| initializeIfNeeded(isInternalUser: false) |
There was a problem hiding this comment.
I think it could be a good time to get rid of isInternalUser parameter and that old migration, wdyt?
There was a problem hiding this comment.
Right, good idea. Let me do this.
There was a problem hiding this comment.
I've removed the parameter but decided to keep SyncError.failedToMigrate because I'm afraid that if we remove it, error codes will get shifted by 1 (and skew our pixels). I have a task on improving Sync Error reporting in pixels so when I get around to working on that, I'll set error codes manually and will remove this enum case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1205489036222324/f
iOS PR: duckduckgo/iOS#2009
macOS PR: duckduckgo/macos-browser#1622
What kind of version bump will this require?: Major
Description:
This patch allows to control Sync server environment from client apps.
to have it passed around as a reference), can be initialized with ServerEnvironment and can have
baseURL updated after creation
were added to allow overriding server environment
Steps to test this PR:
Refer to platform PRs for testing steps.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template