Code

Sync form factor specific favorites#511

Code

Merged

ayoy merged 61 commits intomainduckduckgo/BrowserServicesKit:mainfrom dominik/sync-ffs-favoritesduckduckgo/BrowserServicesKit:dominik/sync-ffs-favoritesCopy head branch name to clipboardNov 10, 2023

+1,636-475

Commits

Commits on Sep 21, 2023

• Add to-many relationship for favorites folders

  ayoy

  committed
  df433e7

• Update addToFavorites API usage

  ayoy

  committed
  214da43

• Update BookmarkTree and fix unit tests to support form factor specific favorites

  ayoy

  committed
  7d9e0ed

• Make FavoritesConfiguration conform to Equatable and make its api public

  ayoy

  committed
  4f4404e

• Fix favorites syncable representation

  ayoy

  committed
  1c45a40

• Fix FavoritesConfiguration.folderUUIDs

  ayoy

  committed
  0e83557

• Fix favorites folders in MenuBookmarksViewModel

  ayoy

  committed
  0e46410

• Fix populating favorites in Sync response

  ayoy

  committed
  4ea3455

• Rename FavoritesConfiguration to FavoritesDisplayMode

  ayoy

  committed
  2400000

• Fix adding to favorites on iOS

  ayoy

  committed
  d873593

• Fix handling favorites in sync response handler

  ayoy

  committed
  f33013c

• Make favorites display mode public and modifiable in FavoriteListViewModel

  ayoy

  committed
  bad2850

• Make favorites display mode public and modifiable in MenuBookmarksViewModel

  ayoy

  committed
  bb08514

• Remove favoritesDisplayMode from initializers in FavoritesListViewModel and MenuBookmarksViewModel

  ayoy

  committed
  547da01

• Add favoritesDisplayMode to FavoritesListInteracting and MenuBookmarksInteracting

  ayoy

  committed
  161088d

• Set renaming identifier for favoriteFolders

  ayoy

  committed
  bb12fb7

• Remove renamingIdentifier from BookmarkEntity

  ayoy

  committed
  b4d5db3

• Add a helper function to migrate to form factor specific favorites

  ayoy

  committed
  21029fc

• Add UserDefaultsSyncHandler for syncing settings stored in UserDefaults

  ayoy

  committed
  e7db707

• Add SettingSyncHandler class as a base class for all handlers for syncable settings

  ayoy

  committed
  4643781

• Add FavoritesDisplayMode.isDisplayAll

  ayoy

  committed
  08b1419

• Add BookmarkUtils.fetchFavoritesFoldersForUnfavoriting

  ayoy

  committed
  b5ed45b

• Move unfavoriting folders logic to BookmarkEntity

  ayoy

  committed
  d27a0ff

• Add BookmarkUtils.favoritesFoldersForUnfavoriting and keep BookmarkEntity unaware of display mode

  ayoy

  committed
  06f52b4

• Rename FavoritesPlatform with FavoritesFolderID and remove favorites folder IDs from Constants

  ayoy

  committed
  20ac7bd

• Add display mode related API to BookmarkEntity extension

  ayoy

  committed
  8f4f67f

• Remove unneeded code

  ayoy

  committed
  cb8ef49

• Rename FavoritesFolderID all to unified

  ayoy

  committed
  6bd32a3

• Remove FavoriteListViewModel.favoritesFolder

  ayoy

  committed
  ee5b87d

• Restore favoriteFolder in FavoriteListViewModel

  ayoy

  committed
  1c38686

• Update SettingsProviderTests with generic settings test cases

  ayoy

  committed
  669537f

• Update SettingsInitialSyncResponseHandlerTests with generic settings test cases

  ayoy

  committed
  8cddf22

• Update SettingsRegularSyncResponseHandlerTests with generic settings test cases

  ayoy

  committed
  2de2631

• Update Bookmarks Sync Data Provider tests

  ayoy

  committed
  e15e04f

• Add tests to verify that invalid form factor favorites are stored 1:1 by Sync

  ayoy

  committed
  36987ed

• Fix removing a favorite

  ayoy

  committed
  8804d65

• Add a helper function that cleans up favorites after disabling sync

  ayoy

  committed
  3769cd9

• Update favorites display mode definition in view models

  ayoy

  committed
  151c635

• Add unit tests for form factor specific favorites to BookmarkListViewModelTests

  ayoy

  committed
  ade3c2a

• Add unit tests for form factor specific favorites to FavoriteListViewModelTests

  ayoy

  committed
  2b5f202

• Add unit tests in BookmarkUtils related to form factor specific favorites

  ayoy

  committed
  6d3a8e5

• Add documentation to FavoritesDisplayMode

  ayoy

  committed
  b9a242c

• Rename displayAll as displayUnified

  ayoy

  committed
  9fb6381

• Rename native/displayedPlatform -> native/displayedFolder

  ayoy

  committed
  5b00317

• Rename SettingsProvider initializers

  ayoy

  committed
  6fba8ab

• Add prepareLegacyFoldersStructure to BookmarkUtils and change copyFavorites function signature

  ayoy

  committed
  eb24eeb

• Fix tests compilation

  ayoy

  committed
  3ac191b

• Add FavoritesDisplayModeSyncHandlerBase

  ayoy

  committed
  9860874

• Make EmailProtectionSyncHandler public and remove EmailManager from SettingsProvider's parameters

  ayoy

  committed
  d367904

• Make emailManager public in EmailProtectionSyncHandler

  ayoy

  committed
  54d524b

• Revert "Make emailManager public in EmailProtectionSyncHandler"

  Show description for 4df0990
  ayoy

  committed
  4df0990

• Make BookmarkEditorViewModel.favoritesDisplayMode public

  ayoy

  committed
  5e7521f

• Fix BookmarkListInteracting.createBookmark for FFS favorites

  ayoy

  committed
  ed95274

• Make BookmarkUtils.fetchLegacyFavoritesFolder public

  ayoy

  committed
  0325036

Commits on Oct 11, 2023

• Merge branch 'main' into dominik/sync-ffs-favorites

  ayoy

  committed
  82c828a

• Make Swiftlint happy

  ayoy

  committed
  95a3c21

Commits on Oct 13, 2023

• Merge branch 'main' into dominik/sync-ffs-favorites

  ayoy

  committed
  c9e4e96

Commits on Oct 29, 2023

• Merge branch 'main' into dominik/sync-ffs-favorites

  ayoy

  committed
  e2480a2

Commits on Oct 31, 2023

• Fix syncing empty favorites folders

  ayoy

  committed
  9068189

Commits on Nov 7, 2023

• Merge branch 'main' into dominik/sync-ffs-favorites

  ayoy

  committed
  fc59aff

Commits on Nov 10, 2023

• Merge branch 'main' into dominik/sync-ffs-favorites

  ayoy

  committed
  3e912b7