Add Sync feature flags #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dates to sync feature flag updating
samsymons
added a commit
that referenced
this pull request
Dec 21, 2023
* main: (39 commits) Fix privacy config fetch in debug mode (#606) Expose Internal User managing from Config (#610) Add Sync feature flags (#607) Fix Networking import into TestUtils (#609) Add Sync Success Rate pixel (#605) Add new logger (#604) Prevent VPN server list persistence failures (#603) SwiftLint plugin (#393) Update autofill to 10.0.2 (#599) Remove the reconnect/disconnect logic from the connection tester Fix an IPv6 regression. (#598) Quality metrics for Sync (#597) Report NetP connection attempts, tunnel failures, and latency (#584) Implement deleteAccount Sync endpoint (#596) Ensure that LinkPresentation framework is called on main thread (#595) No longer excluding the 10.0.0.0/8 range (#594) Update autofill to 10.0.1 (#591) Implement deleteAccount Sync endpoint (#596) Ensure that LinkPresentation framework is called on main thread (#595) No longer excluding the 10.0.0.0/8 range (#594) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1206046777189407/f
iOS PR: duckduckgo/iOS#2279
macOS PR: duckduckgo/macos-browser#1992
What kind of version bump will this require?: Major
Description:
This change add support for Sync feature in Privacy Configuration, together with
4 subfeatures defining availability of various parts of Sync experience.
DDGSyncing gets a read-only feature flag variable as well as a publisher.
PrivacyConfigurationManager is now a Sync dependency, and DDGSync takes
care internally of listening to Privacy Config changes and updating feature flags
as needed.
Feature flag responsible for actual data syncing is handled internally in DDGSync
by cancelling all pending sync operations and disabling adding new operations.
Other feature flags should be handled by client apps.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template