Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a crash in the VPN #685

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fixes a crash in the VPN #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Sources/NetworkProtection/Diagnostics/NetworkProtectionConnectionTester.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,17 @@ final class NetworkProtectionConnectionTester {
}
}

timer.setCancelHandler { [weak self] in
self?.timer = nil
}
// Enable back if needed. The only reason this commented code is left in is because it has
// documentation purposes, and while the timer should not be released here, it's ok to enable
// back the cancellation handler if it's needed for other purposes.
//
// timer.setCancelHandler { [weak self] in
// Do not re-enable this.
// Releasing the timer here is causing a crash. I'm leaving this here for documentation
// purposes, so that we're not tempted to add this back.
//
// self?.timer = nil
// }

timer.resume()
}
Expand Down
Loading