Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autofill Script performance improvements #740

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Autofill Script performance improvements #740

merged 3 commits into from
Mar 25, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Mar 22, 2024 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/414709148257752/1206900948756760/f
iOS PR: duckduckgo/iOS#2625
macOS PR: duckduckgo/macos-browser#2481
What kind of version bump will this require?: Patch

Optional:

Tech Design URL:
CC:

Description:
Greatly reduces the amount of data passed into the autofill script to improve performance and resolve occasional out of memory crashes

Steps to test this PR:

  1. See clients PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12
Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44
Filtering out large amounts of unnecessary data from the privacy conf…
b7082af 
…ig when populating the autofill script to improve performance and resolve memory related crashes
aataraxiaa
aataraxiaa approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thought - this might be time critical due to upcoming release, but one idea would be to add tests for this to AutofillUserScriptSourceProviderTests. (Although I have not taken a deep look at how testable the type is).

@amddg44 amddg44 merged commit 0509e0c into main Mar 25, 2024
7 checks passed
@amddg44 amddg44 deleted the anya/autofill-script-perf-improvements branch March 25, 2024 13:18
samsymons added a commit that referenced this pull request Mar 25, 2024
@samsymons
Merge branch 'main' into sam/startup-logging-cleanup
e888df9 
* main:
  Autofill Script performance improvements (#740)
  Update subscription and accounts cache after the confirmation of purchase completes (#746)
  Send correct platform value for App Store purchase options (#747)
  Collect extra metadata (#737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aataraxiaa aataraxiaa aataraxiaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amddg44 @aataraxiaa