Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for uploading crash reports to Sentry #777

Merged
merged 19 commits into from
Apr 18, 2024
Merged

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Apr 11, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/72649045549333/1205862129634403/f
iOS PR: duckduckgo/iOS#2720
macOS PR: duckduckgo/macos-browser#2605
What kind of version bump will this require?: Major

Description:
Add CrashReportSender (moved over from the macOS app) and update CrashCollection
to support sending crashes reported by MetricKit to the backend.

Steps to test this PR:
See platform PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Apr 11, 2024
@@ -407,6 +410,13 @@ let package = Package(
],
plugins: [swiftlintPlugin]
),
.testTarget(
name: "CrashesTests",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a single test case that I moved from iOS because it didn't depend on the iOS app at all.

@@ -19,61 +19,86 @@
import Foundation
import MetricKit

public enum CrashCollectionPlatform {
case iOS, macOS, macOSAppStore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CrashCollection itself (MetricKit adapter) only uses iOS and macOSAppStore, but this enum is consumed by CrashReportSender that is the common interface to our backend and handles all 3 cases.

@ayoy ayoy marked this pull request as ready for review April 12, 2024 13:24
@ayoy ayoy requested a review from samsymons April 12, 2024 14:24
@ayoy ayoy assigned samsymons and unassigned ayoy Apr 12, 2024
@ayoy ayoy assigned ayoy and unassigned samsymons Apr 18, 2024
@ayoy ayoy merged commit 4ce0496 into main Apr 18, 2024
7 checks passed
@ayoy ayoy deleted the dominik/sentry-appstore branch April 18, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants