-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for uploading crash reports to Sentry #777
Conversation
@@ -407,6 +410,13 @@ let package = Package( | |||
], | |||
plugins: [swiftlintPlugin] | |||
), | |||
.testTarget( | |||
name: "CrashesTests", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a single test case that I moved from iOS because it didn't depend on the iOS app at all.
@@ -19,61 +19,86 @@ | |||
import Foundation | |||
import MetricKit | |||
|
|||
public enum CrashCollectionPlatform { | |||
case iOS, macOS, macOSAppStore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CrashCollection
itself (MetricKit adapter) only uses iOS
and macOSAppStore
, but this enum is consumed by CrashReportSender
that is the common interface to our backend and handles all 3 cases.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1205862129634403/f
iOS PR: duckduckgo/iOS#2720
macOS PR: duckduckgo/macos-browser#2605
What kind of version bump will this require?: Major
Description:
Add CrashReportSender (moved over from the macOS app) and update CrashCollection
to support sending crashes reported by MetricKit to the backend.
Steps to test this PR:
See platform PRs
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template