Logging refactoring #1 Subscription and Content Blocking #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicocappelli
changed the title
federicocappelli
requested review from
a team and
diegoreymendez
and removed request for
a team and
diegoreymendez
| @@ -16,6 +16,8 @@ disabled_rules: | |||
| - function_body_length | |||
| - file_length | |||
| - type_body_length | |||
| - static_over_final_class | |||
| - non_optional_string_data_conversion | |||
There was a problem hiding this comment.
rules enabled automatically in the new swiftlint that I'm using locally, with this we have dozens of errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206750146033742/f
iOS PR: duckduckgo/iOS#3219
macOS PR: duckduckgo/macos-browser#3091
What kind of version bump will this require?: Major, breaking change
Optional:
Tech Design URL: https://app.asana.com/0/1200194497630846/1206777133329590/f
CC: @ayoy @bwaresiak
Description:
Step 1 of the Logging refactoring
Steps to test this PR:
Check subscription and content blocker logs are working
Internal references:
Software Engineering Expectations
Technical Design Template