Expose tracker ownedBy field #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandroboron
requested review from
bwaresiak,
brindy,
samsymons and
THISISDINOSAUR
as code owners
alessandroboron
deleted the
alessandro/fix-site-owned-by-major-network
branch
Tmfc3242
reviewed
Nov 17, 2024
| let trackerData = try JSONDecoder().decode(TrackerData.self, from: JSONTestDataLoader.trackerData) | ||
|
|
||
| // WHEN | ||
| var owner = trackerData.trackers["instagram.com"]?.owner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1176956903599313/1208164650000833/f
Description:
There’s an existing issue that causes showing the wrong education dialog for websites that are owned by a major network like Facebook and Google.
In addition, the Privacy Dashboard does not reflect weather an entity is owned by a major tracker
This PR exposes the field “ownedBy” with the purpose of identifying when a tracker is owned by another entity. e.g. Instagram is ownedBy is Facebook
Steps to test this PR:
OS Testing:
iOS 14
iOS 15
macOS 10.15
macOS 11
macOS 12
Internal references:
Software Engineering Expectations
Technical Design Template