Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reimplement XCProject #4

Merged
merged 2 commits into from
Apr 18, 2024
Merged

reimplement XCProject #4

merged 2 commits into from
Apr 18, 2024

Conversation

mallexxx
Copy link
Contributor

Task URL: https://app.asana.com/0/1201037661562251/1206803066031565/f
BSK PR: duckduckgo/BrowserServicesKit#774
iOS PR: duckduckgo/iOS#2710
macOS PR: duckduckgo/macos-browser#2601

Release type: Minor

Description:

Steps to test:

  • Validate swiftlint works in DuckDuckGo xcode project

@mallexxx mallexxx requested a review from ayoy April 18, 2024 08:33
ayoy
ayoy approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks! I also love how much simpler the code gets 👏

@mallexxx mallexxx merged commit 4aa8ff7 into main Apr 18, 2024
@mallexxx mallexxx mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayoy ayoy ayoy approved these changes

Assignees

@mallexxx mallexxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @ayoy