Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XRay code and switch to main world content script in Firefox #1314

Merged
merged 11 commits into from
Jan 7, 2025

Conversation

muodov
Copy link
Member

@muodov muodov commented Dec 11, 2024

Asana Task/Github Issue:
https://app.asana.com/0/1201614831475344/1207277833550158/f

Description

Firefox now supports execution worlds for content scripts in their MV2 manifest. This allows us to remove xray code. See also duckduckgo/duckduckgo-privacy-extension#2852

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 20f3821
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/677d234376200800085067fa
😎 Deploy Preview https://deploy-preview-1314--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 11, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Dec 11, 2024

[Beta] Generated file diff

Time updated: Tue, 07 Jan 2025 12:52:12 GMT

Android
    - android/autofillPasswordImport.js
  • android/contentScope.js

File has changed

Chrome
    - chrome/inject.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@muodov muodov marked this pull request as ready for review December 11, 2024 13:32
@muodov muodov requested review from kzar, sammacbeth and a team as code owners December 11, 2024 13:32
@muodov muodov merged commit 3df3d1b into main Jan 7, 2025
12 checks passed
@muodov muodov deleted the max/ff-mv3 branch January 7, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants