-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity Widget: Windows optimized API #1441
Closed
greyivy
wants to merge
24
commits into
01-21-ntp_activity_widget
from
igrey/activity-optimization-api
Closed
Activity Widget: Windows optimized API #1441
greyivy
wants to merge
24
commits into
01-21-ntp_activity_widget
from
igrey/activity-optimization-api
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0dc1f67.
❌ Deploy Preview for content-scope-scripts failed.
|
836da75
to
2227fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
Description
Implements a "fetched" API for Windows while maintaining compatibility with the existing API.
Usage examples
In reply to
GetData
(the previous format can still be used)activity_getUrls
When notifying
OnDataUpdate
(the previous format can still be used)activitiy_onDataPatch
Note that
patch
is optional here (and only used when patching existing records, not creating or deleting)The frontend sends
activity_getDataForUrls
with a list ofurls
as needed......and the native side responds with an array of
Domain Activity
recordsTesting Steps
Checklist
Please tick all that apply: