fix: make credentials storing more liberal

src/Form/Form.js

@@ -240,8 +240,7 @@ class Form {
      */
     getValuesReadyForStorage() {
         const formValues = this.getRawValues();
-        const hasOnlyOneCredential = this.inputs.credentials.size === 1;
-        return prepareFormValuesForStorage(formValues, hasOnlyOneCredential);
+        return prepareFormValuesForStorage(formValues);
     }
 
     /**

src/Form/Form.test.js

@@ -84,8 +84,8 @@ describe('Test the form class reading values correctly', () => {
     <input type="password" value="" autocomplete="new-password" />
     <button type="submit">Sign up</button>
 </form>`,
-            expHasValues: false,
-            expValues: { credentials: undefined },
+            expHasValues: true,
+            expValues: { credentials: { username: 'testUsername' } },
         },
         {
             testCase: 'form where the password is <=3 characters long',
@@ -95,8 +95,8 @@ describe('Test the form class reading values correctly', () => {
     <input type="password" value="abc" autocomplete="new-password" />
     <button type="submit">Sign up</button>
 </form>`,
-            expHasValues: false,
-            expValues: { credentials: undefined },
+            expHasValues: true,
+            expValues: { credentials: { username: 'testUsername' } },
         },
         {
             testCase: 'form with hidden email field',

src/Form/formatters.js

@@ -159,18 +159,6 @@ const getMMAndYYYYFromString = (expiration) => {
     );
 };
 
-/**
- * @param {InternalDataStorageObject} credentials
- * @return {boolean}
- */
-const shouldStoreCredentials = ({ credentials }, hasOnlyOneCredential) => {
-    if (credentials.password) {
-        return Boolean(credentials.password);
-    } else {
-        return hasOnlyOneCredential && Boolean(credentials.username);
-    }
-};
-
 /**
  * @param {InternalDataStorageObject} credentials
  * @return {boolean}
@@ -207,10 +195,9 @@ const formatPhoneNumber = (phone) => phone.replaceAll(/[^0-9|+]/g, '');
  * Formats form data into an object to send to the device for storage
  * If values are insufficient for a complete entry, they are discarded
  * @param {InternalDataStorageObject} formValues
- * @param {boolean} hasOnlyOneCredential
  * @return {DataStorageObject}
  */
-const prepareFormValuesForStorage = (formValues, hasOnlyOneCredential) => {
+const prepareFormValuesForStorage = (formValues) => {
     /** @type {Partial<InternalDataStorageObject>} */
     let { credentials, identities, creditCards } = formValues;
 
@@ -219,9 +206,8 @@ const prepareFormValuesForStorage = (formValues, hasOnlyOneCredential) => {
         creditCards.cardName = identities?.fullName || formatFullName(identities);
     }
 
-    /** Fixes for credentials **/
-    // Don't store if there isn't enough data
-    if (shouldStoreCredentials(formValues, hasOnlyOneCredential)) {
+    /** Fixes for credentials */
+    if (credentials.username || credentials.password) {
         // If we don't have a username to match a password, let's see if the email is available
         if (credentials.password && !credentials.username && identities.emailAddress) {
             credentials.username = identities.emailAddress;

src/Form/formatters.test.js

@@ -62,44 +62,35 @@ describe('Can strip phone formatting characters', () => {
 describe('prepareFormValuesForStorage()', () => {
     describe('handling credentials', () => {
         it('accepts for username only', () => {
-            const values = prepareFormValuesForStorage(
-                {
-                    credentials: { username: '[email protected]' },
-                    // @ts-ignore
-                    creditCards: {},
-                    // @ts-ignore
-                    identities: {},
-                },
-                true,
-            );
+            const values = prepareFormValuesForStorage({
+                credentials: { username: '[email protected]' },
+                // @ts-ignore
+                creditCards: {},
+                // @ts-ignore
+                identities: {},
+            });
             expect(values.credentials?.username).toBe('[email protected]');
         });
         it('accepts password only', () => {
-            const values = prepareFormValuesForStorage(
-                {
-                    // @ts-ignore
-                    credentials: { password: '123456' },
-                    // @ts-ignore
-                    creditCards: {},
-                    // @ts-ignore
-                    identities: {},
-                },
-                false,
-            );
+            const values = prepareFormValuesForStorage({
+                // @ts-ignore
+                credentials: { password: '123456' },
+                // @ts-ignore
+                creditCards: {},
+                // @ts-ignore
+                identities: {},
+            });
             expect(values.credentials?.password).toBe('123456');
         });
         it('accepts username+password', () => {
             const inputCredentials = { username: '[email protected]', password: '123456' };
-            const values = prepareFormValuesForStorage(
-                {
-                    credentials: inputCredentials,
-                    // @ts-ignore
-                    creditCards: {},
-                    // @ts-ignore
-                    identities: {},
-                },
-                false,
-            );
+            const values = prepareFormValuesForStorage({
+                credentials: inputCredentials,
+                // @ts-ignore
+                creditCards: {},
+                // @ts-ignore
+                identities: {},
+            });
             expect(values.credentials).toEqual(inputCredentials);
         });
     });