Better fix

Signed-off-by: Emanuele Feliziani <[email protected]>
duckduckgo · Oct 31, 2023 · 40a035f · 40a035f
1 parent 057ab8c
commit 40a035f
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 12 deletions.
diff --git a/dist/autofill-debug.js b/dist/autofill-debug.js
diff --git a/dist/autofill.js b/dist/autofill.js
diff --git a/src/Form/matching-config/__generated__/compiled-matching-config.js b/src/Form/matching-config/__generated__/compiled-matching-config.js
diff --git a/src/Form/matching-config/matching-config-source.js b/src/Form/matching-config/matching-config-source.js
@@ -264,7 +264,7 @@ const matchingConfiguration = {
                         '|clave|contraseña' +
                         // Swedish
                         '|lösenord',
-                    skip: 'email|one-time|error|hint|username',
+                    skip: 'email|one-time|error|hint',
                     forceUnknown: 'captcha|mfa|2fa|two factor|otp|pin'
                 },
                 username: {

diff --git a/src/Form/matching.js b/src/Form/matching.js
@@ -258,7 +258,8 @@ class Matching {
                 if (
                     ['password', 'text'].includes(input.type) &&
                     input.name !== 'email' &&
-                    input.placeholder !== 'Username'
+                    // pcsretirement.com, improper use of the for attribute
+                    input.name !== 'Username'
                 ) {
                     return 'credentials.password'
                 }

diff --git a/src/Form/test-cases/pcsretirementcom_login.html b/src/Form/test-cases/pcsretirementcom_login.html
@@ -51,4 +51,5 @@
     </div>
 
     <input id="RequestClientIp" name="RequestClientIp" type="hidden" value="">
-    <input name="__RequestVerificationToken" type="hidden" value="CfDJ8HnUUXEcWsVAgsnceZ6J-X6_Oq0F840ZVBUdV12lF41SqPnfe6NC4PzG2m3rSzPWBPG9GuQEhWy8kEHE1OH7WQxn0zk0EYECYxtNuVljuBTYhG19JDmOJXVydD_Xs2rCaJTKmJCCYx_7MnWptRijbEs"></form>
+    <input name="__RequestVerificationToken" type="hidden" value="CfDJ8HnUUXEcWsVAgsnceZ6J-X6_Oq0F840ZVBUdV12lF41SqPnfe6NC4PzG2m3rSzPWBPG9GuQEhWy8kEHE1OH7WQxn0zk0EYECYxtNuVljuBTYhG19JDmOJXVydD_Xs2rCaJTKmJCCYx_7MnWptRijbEs">
+</form>
diff --git a/swift-package/Resources/assets/autofill-debug.js b/swift-package/Resources/assets/autofill-debug.js
diff --git a/swift-package/Resources/assets/autofill.js b/swift-package/Resources/assets/autofill.js