Skip to content

Commit

Permalink
Ema/perf followups (#386)
Browse files Browse the repository at this point in the history
* Safeguard regexes against huge strings

Signed-off-by: Emanuele Feliziani <[email protected]>

* Add perf regression testing

Signed-off-by: Emanuele Feliziani <[email protected]>

* Bump up the timeout

Signed-off-by: Emanuele Feliziani <[email protected]>

* Bump timeouts again

Signed-off-by: Emanuele Feliziani <[email protected]>

---------

Signed-off-by: Emanuele Feliziani <[email protected]>
  • Loading branch information
GioSensation authored Oct 2, 2023
1 parent 55466f1 commit 84127e0
Show file tree
Hide file tree
Showing 13 changed files with 4,537 additions and 131 deletions.
62 changes: 38 additions & 24 deletions dist/autofill-debug.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

62 changes: 38 additions & 24 deletions dist/autofill.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration-test/helpers/harness.js
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export function forwardConsoleMessages (page, _opts = {}) {
*/
export async function performanceEntries (page, measureName) {
// don't measure until the entries exist
await page.waitForFunction((measureName) => window.performance.getEntriesByName(measureName).length > 0, `${measureName}:end`)
await page.waitForFunction((measureName) => window.performance.getEntriesByName(measureName).length > 0, `${measureName}:end`, { timeout: 5000 })
const result = await page.evaluate((measureName) => {
window.performance?.measure?.(measureName, `${measureName}:start`, `${measureName}:end`)
const entries = window.performance?.getEntriesByName(measureName)
Expand Down
Loading

0 comments on commit 84127e0

Please sign in to comment.