Skip to content

Commit

Permalink
wip: split manage calls for apple/windows
Browse files Browse the repository at this point in the history
  • Loading branch information
dbajpeyi committed Dec 12, 2024
1 parent 88982a3 commit b98d24e
Show file tree
Hide file tree
Showing 7 changed files with 45 additions and 20 deletions.
13 changes: 9 additions & 4 deletions dist/autofill-debug.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 9 additions & 4 deletions dist/autofill.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/DeviceInterface/AppleDeviceInterface.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,20 +217,23 @@ class AppleDeviceInterface extends InterfacePrototype {
* Opens the native UI for managing passwords
*/
openManagePasswords() {
this._closeAutofillParent();
return this.deviceApi.notify(createNotification('pmHandlerOpenManagePasswords'));
}

/**
* Opens the native UI for managing identities
*/
openManageIdentities() {
this._closeAutofillParent();
return this.deviceApi.notify(createNotification('pmHandlerOpenManageIdentities'));
}

/**
* Opens the native UI for managing credit cards
*/
openManageCreditCards() {
this._closeAutofillParent();
return this.deviceApi.notify(createNotification('pmHandlerOpenManageCreditCards'));
}

Expand Down
9 changes: 6 additions & 3 deletions src/DeviceInterface/WindowsOverlayDeviceInterface.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,19 +102,22 @@ export class WindowsOverlayDeviceInterface extends InterfacePrototype {
* @returns {Promise<any>}
*/
openManagePasswords() {
return this.deviceApi.notify(new OpenManagePasswordsCall({}));
this.deviceApi.notify(new OpenManagePasswordsCall({}));
return this._closeAutofillParent();
}
/**
* @returns {Promise<any>}
*/
openManageCreditCards() {
return this.deviceApi.notify(new OpenManageCreditCardsCall({}));
this.deviceApi.notify(new OpenManageCreditCardsCall({}));
return this._closeAutofillParent();
}
/**
* @returns {Promise<any>}
*/
openManageIdentities() {
return this.deviceApi.notify(new OpenManageIdentitiesCall({}));
this.deviceApi.notify(new OpenManageIdentitiesCall({}));
return this._closeAutofillParent();
}

/**
Expand Down
1 change: 0 additions & 1 deletion src/UI/controllers/HTMLTooltipUIController.js
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,6 @@ export class HTMLTooltipUIController extends UIController {
* @private
*/
_onManage(type) {
this.removeTooltip();
switch (type) {
case 'credentials':
return this._options.device.openManagePasswords();
Expand Down
13 changes: 9 additions & 4 deletions swift-package/Resources/assets/autofill-debug.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 9 additions & 4 deletions swift-package/Resources/assets/autofill.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b98d24e

Please sign in to comment.