feat: prompt when autofilled

duckduckgo · Nov 25, 2024 · d8c7d83 · d8c7d83
1 parent e1030b4
commit d8c7d83
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 5 deletions.
diff --git a/dist/autofill-debug.js b/dist/autofill-debug.js
diff --git a/dist/autofill.js b/dist/autofill.js
diff --git a/src/Form/Form.js b/src/Form/Form.js
@@ -902,10 +902,15 @@ class Form {
 
         // After autofill we check if form values match the data provided…
         const formValues = this.getValuesReadyForStorage();
+        const hasOnlyOneCredential =
+            (Boolean(formValues.credentials?.username) && !formValues.credentials?.password) ||
+            (Boolean(formValues.credentials?.password) && !formValues.credentials?.username);
         const areAllFormValuesKnown = Object.keys(formValues[dataType] || {}).every(
             (subtype) => formValues[dataType][subtype] === data[subtype],
         );
-        if (areAllFormValuesKnown) {
+        // If all form values are known, but we only have a single credntial field - then we want to prompt a partial save with username,
+        // So that in multi step forms (like reset-password), we can identify which username was picked, or complete a password save.
+        if (areAllFormValuesKnown && !hasOnlyOneCredential) {
             // …if we know all the values do not prompt to store data
             this.shouldPromptToStoreData = false;
             // reset this to its initial value

diff --git a/swift-package/Resources/assets/autofill-debug.js b/swift-package/Resources/assets/autofill-debug.js
diff --git a/swift-package/Resources/assets/autofill.js b/swift-package/Resources/assets/autofill.js