Fix perf regressions #385
Merged
Fix perf regressions #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Feliziani <[email protected]>
GioSensation
commented
Sep 27, 2023
| !string || | ||
| string.length > constants.TEXT_LENGTH_CUTOFF | ||
| ) return this | ||
|
|
There was a problem hiding this comment.
This is the meat of the fix. We want to avoid running several regex checks on potentially huge chunks of text. This is what was causing the issues.
GioSensation
commented
Sep 27, 2023
| const headings = document.querySelectorAll('h1, h2, h3, [class*="title"], [id*="title"]') | ||
| headings.forEach(({textContent}) => { | ||
| textContent = removeExcessWhitespace(textContent || '') | ||
| const headings = document.querySelectorAll('h1, h2, h3') |
There was a problem hiding this comment.
Removed [class*="title"], [id*="title"] to avoid catching a bunch of useless stuff.
GioSensation
commented
Sep 27, 2023
| @@ -256,10 +263,7 @@ class FormAnalyzer { | |||
| this.updateSignal({string, strength, signalType: `external link: ${string}`, shouldFlip}) | |||
| } else { | |||
| // any other case | |||
| // only consider the el if it's a small text to avoid noisy disclaimers | |||
| if (removeExcessWhitespace(el.textContent)?.length < constants.TEXT_LENGTH_CUTOFF) { | |||
There was a problem hiding this comment.
The length check has been moved to updateSignal so we're sure all these regexes are safeguarded against extra long text.
GioSensation
commented
Sep 27, 2023
| @@ -231,6 +231,9 @@ class DefaultScanner { | |||
| return | |||
| } | |||
|
|
|||
| // Do not add explicitly search forms | |||
| if (parentForm.role === 'search') return | |||
There was a problem hiding this comment.
Just occurred to me we shouldn't even add these obvious search forms, whenever web authors are kind enough to mark them as such. Now there's a new search html element, but not worth bothering about it now.
shakyShane
approved these changes
Sep 27, 2023
This was referenced Sep 28, 2023
brindy
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 28, 2023
Task/Issue URL: https://app.asana.com/0/1205602928782192/1205602928782192 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.4.1 BSK PR: duckduckgo/BrowserServicesKit#517 ## Description Updates Autofill to version [8.4.1](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.4.1). ### Autofill 8.4.1 release notes ## What's Changed * Precompile regexes by @GioSensation in duckduckgo/duckduckgo-autofill#382 * Add perf tests by @GioSensation in duckduckgo/duckduckgo-autofill#383 * deps: remove deprecated content-scope-utils by @shakyShane in duckduckgo/duckduckgo-autofill#384 * Update dependencies by @GioSensation in duckduckgo/duckduckgo-autofill#368 * Fix perf regressions by @GioSensation in duckduckgo/duckduckgo-autofill#385 **Full Changelog**: duckduckgo/duckduckgo-autofill@8.4.0...8.4.1 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). --------- Co-authored-by: GioSensation <[email protected]> Co-authored-by: Chris Brind <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane
Asana: https://app.asana.com/0/0/1205589679117410/f
Description
Prevent certain regex checks to run on huge strings.
Steps to test