Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ema/perf followups #386

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Ema/perf followups #386

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
930e3ca
Safeguard regexes against huge strings
GioSensation Sep 29, 2023
8d3d7ee
Add perf regression testing
GioSensation Sep 29, 2023
5ccb3b9
Bump up the timeout
GioSensation Sep 29, 2023
de93e7a
Bump timeouts again
GioSensation Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 38 additions & 24 deletions dist/autofill-debug.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

62 changes: 38 additions & 24 deletions dist/autofill.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion integration-test/helpers/harness.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@
*/
export async function performanceEntries (page, measureName) {
// don't measure until the entries exist
await page.waitForFunction((measureName) => window.performance.getEntriesByName(measureName).length > 0, `${measureName}:end`)
await page.waitForFunction((measureName) => window.performance.getEntriesByName(measureName).length > 0, `${measureName}:end`, { timeout: 2000 })

Check failure on line 218 in integration-test/helpers/harness.js

View workflow job for this annotation

GitHub Actions / test

[macos] › email-autofill.macos.spec.js:321:9 › macos › matching performance › large dom with potentially huge regex checks 

  1) [macos] › email-autofill.macos.spec.js:321:9 › macos › matching performance › large dom with potentially huge regex checks 
    TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.

       at ../helpers/harness.js:218

      216 | export async function performanceEntries (page, measureName) {
      217 |     // don't measure until the entries exist
    > 218 |     await page.waitForFunction((measureName) => window.performance.getEntriesByName(measureName).length > 0, `${measureName}:end`, { timeout: 2000 })
          |                ^
      219 |     const result = await page.evaluate((measureName) => {
      220 |         window.performance?.measure?.(measureName, `${measureName}:start`, `${measureName}:end`)
      221 |         const entries = window.performance?.getEntriesByName(measureName)

        at performanceEntries (/home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/helpers/harness.js:218:16)
        at Object.validateInitialScanPerf (/home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/helpers/pages.js:752:35)
        at /home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/tests/email-autofill.macos.spec.js:333:28

Check failure on line 218 in integration-test/helpers/harness.js

View workflow job for this annotation

GitHub Actions / test

[macos] › email-autofill.macos.spec.js:321:9 › macos › matching performance › large dom with potentially huge regex checks 

  1) [macos] › email-autofill.macos.spec.js:321:9 › macos › matching performance › large dom with potentially huge regex checks 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.

       at ../helpers/harness.js:218

      216 | export async function performanceEntries (page, measureName) {
      217 |     // don't measure until the entries exist
    > 218 |     await page.waitForFunction((measureName) => window.performance.getEntriesByName(measureName).length > 0, `${measureName}:end`, { timeout: 2000 })
          |                ^
      219 |     const result = await page.evaluate((measureName) => {
      220 |         window.performance?.measure?.(measureName, `${measureName}:start`, `${measureName}:end`)
      221 |         const entries = window.performance?.getEntriesByName(measureName)

        at performanceEntries (/home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/helpers/harness.js:218:16)
        at Object.validateInitialScanPerf (/home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/helpers/pages.js:752:35)
        at /home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/tests/email-autofill.macos.spec.js:333:28

Check failure on line 218 in integration-test/helpers/harness.js

View workflow job for this annotation

GitHub Actions / test

[macos] › email-autofill.macos.spec.js:321:9 › macos › matching performance › large dom with potentially huge regex checks 

  1) [macos] › email-autofill.macos.spec.js:321:9 › macos › matching performance › large dom with potentially huge regex checks 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.

       at ../helpers/harness.js:218

      216 | export async function performanceEntries (page, measureName) {
      217 |     // don't measure until the entries exist
    > 218 |     await page.waitForFunction((measureName) => window.performance.getEntriesByName(measureName).length > 0, `${measureName}:end`, { timeout: 2000 })
          |                ^
      219 |     const result = await page.evaluate((measureName) => {
      220 |         window.performance?.measure?.(measureName, `${measureName}:start`, `${measureName}:end`)
      221 |         const entries = window.performance?.getEntriesByName(measureName)

        at performanceEntries (/home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/helpers/harness.js:218:16)
        at Object.validateInitialScanPerf (/home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/helpers/pages.js:752:35)
        at /home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/tests/email-autofill.macos.spec.js:333:28

Check failure on line 218 in integration-test/helpers/harness.js

View workflow job for this annotation

GitHub Actions / test

[macos] › email-autofill.macos.spec.js:321:9 › macos › matching performance › large dom with potentially huge regex checks 

  1) [macos] › email-autofill.macos.spec.js:321:9 › macos › matching performance › large dom with potentially huge regex checks 

    Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
    TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.

       at ../helpers/harness.js:218

      216 | export async function performanceEntries (page, measureName) {
      217 |     // don't measure until the entries exist
    > 218 |     await page.waitForFunction((measureName) => window.performance.getEntriesByName(measureName).length > 0, `${measureName}:end`, { timeout: 2000 })
          |                ^
      219 |     const result = await page.evaluate((measureName) => {
      220 |         window.performance?.measure?.(measureName, `${measureName}:start`, `${measureName}:end`)
      221 |         const entries = window.performance?.getEntriesByName(measureName)

        at performanceEntries (/home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/helpers/harness.js:218:16)
        at Object.validateInitialScanPerf (/home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/helpers/pages.js:752:35)
        at /home/runner/work/duckduckgo-autofill/duckduckgo-autofill/integration-test/tests/email-autofill.macos.spec.js:333:28
const result = await page.evaluate((measureName) => {
window.performance?.measure?.(measureName, `${measureName}:start`, `${measureName}:end`)
const entries = window.performance?.getEntriesByName(measureName)
Expand Down
Loading
Loading