Revert mutation observer for forms

integration-test/tests/mutating-form.macos.spec.js

@@ -8,7 +8,7 @@ import {test as base} from '@playwright/test'
  */
 const test = base.extend({})
 
-test.describe('Mutating form page', () => {
+test.describe.skip('Mutating form page', () => {
     async function applyScript (page) {
         await createAutofillScript()
             .replaceAll(macosContentScopeReplacements())

src/Form/Form.js

@@ -26,7 +26,6 @@ import {constants} from '../constants.js'
 const {
     ATTR_AUTOFILL,
     ATTR_INPUT_TYPE,
-    MAX_FORM_MUT_OBS_COUNT,
     MAX_INPUTS_PER_FORM
 } = constants
 
@@ -77,30 +76,6 @@ class Form {
             }
         })
 
-        this.mutObsCount = 0
-        this.mutObsConfig = { childList: true, subtree: true }
-        this.mutObs = new MutationObserver(
-            (records) => {
-                const anythingRemoved = records.some(record => record.removedNodes.length > 0)
-                if (anythingRemoved) {
-                    // Must check for inputs because a parent may be removed and not show up in record.removedNodes
-                    if ([...this.inputs.all].some(input => !input.isConnected)) {
-                        // If any known input has been removed from the DOM, reanalyze the whole form
-                        window.requestIdleCallback(() => {
-                            this.formAnalyzer = new FormAnalyzer(this.form, input, this.matching)
-                            this.recategorizeAllInputs()
-                        })
-
-                        this.mutObsCount++
-                        // If the form mutates too much, disconnect to avoid performance issues
-                        if (this.mutObsCount >= MAX_FORM_MUT_OBS_COUNT) {
-                            this.mutObs.disconnect()
-                        }
-                    }
-                }
-            }
-        )
-
         // This ensures we fire the handler again if the form is changed
         this.addListener(form, 'input', () => {
             if (!this.isAutofilling) {
@@ -110,7 +85,6 @@ class Form {
         })
 
         this.categorizeInputs()
-        this.mutObs.observe(this.form, this.mutObsConfig)
 
         this.logFormInfo()
 
@@ -356,7 +330,6 @@ class Form {
         this.removeAllDecorations()
         this.removeTooltip()
         this.forgetAllInputs()
-        this.mutObs.disconnect()
         this.matching.clear()
         this.intObs = null
     }
@@ -444,13 +417,6 @@ class Form {
             return this
         }
 
-        // When new inputs are added after the initial scan, reanalyze the whole form
-        if (this.initialScanComplete) {
-            this.formAnalyzer = new FormAnalyzer(this.form, input, this.matching)
-            this.recategorizeAllInputs()
-            return this
-        }
-
         // Nothing to do with 1-character fields
         if (input.maxLength === 1) return this
 

src/Scanner.js

@@ -226,8 +226,13 @@ class DefaultScanner {
         const parentForm = this.getParentForm(input)
 
         if (parentForm instanceof HTMLFormElement && this.forms.has(parentForm)) {
-            // We've met the form, add the input
-            this.forms.get(parentForm)?.addInput(input)
+            const foundForm = this.forms.get(parentForm)
+            // We've met the form, add the input provided it's below the max input limit
+            if (foundForm && foundForm.inputs.all.size < MAX_INPUTS_PER_FORM) {
+                foundForm.addInput(input)
+            } else {
+                this.stopScanner('The form has too many inputs, destroying.')
+            }
             return
         }