Set up in-context signup for Android #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistairjcbrown
force-pushed
the
abrown/android-incontext-email-promotion
branch
from
b6bb3c0 to
51d1f44
Compare
GioSensation
approved these changes
Oct 16, 2023
|
I've added this one-liner that is also useful to Android in another context. And fixed that typo 😉. |
Signed-off-by: Emanuele Feliziani <[email protected]>
alistairjcbrown
force-pushed
the
abrown/android-incontext-email-promotion
branch
from
f124e36 to
d7ea17d
Compare
|
@GioSensation I've added an integration test which confirm the initial dismissal check and the prompt message being sent when dax is clicked. Most of the flow happens on native UI, so there's not much to test here. |
|
Lovely. Ship it. 🚀 |
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane @GioSensation
Asana: https://app.asana.com/0/0/1205688727602722/f
Description
Adds necessary changes to support in-context signup in Android
Steps to test
See latest test builds -- https://app.asana.com/0/0/1205404319005943/f