Don't call getAvailableInputTypes from topFrame #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Feliziani <[email protected]>
shakyShane
approved these changes
Nov 9, 2023
This was referenced Nov 13, 2023
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Nov 13, 2023
Task/Issue URL: https://app.asana.com/0/1205938901087974/1205938901087974 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.0.0 ## Description Updates Autofill to version [10.0.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.0.0). ### Autofill 10.0.0 release notes ## What's Changed * Don't call getAvailableInputTypes from topFrame by @GioSensation in duckduckgo/duckduckgo-autofill#411 * Super small fix by @GioSensation in duckduckgo/duckduckgo-autofill#412 * Send getRuntimeConfiguration to native on macOS by @GioSensation in duckduckgo/duckduckgo-autofill#379 **Full Changelog**: duckduckgo/duckduckgo-autofill@9.1.0...10.0.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: GioSensation <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane
Asana: https://app.asana.com/0/0/1205907543853472/f
Description
Short-circuits
getAvailableInputTypesin the topFrame to avoid calling the native app unnecessarily. That data is only needed for page scanning which we don't do in that context. Another instance where that architectural decision back then creates unintended problems 😔.Steps to test
Everything should just work as usual in all autofill scenarios. Tom is testing specifically the Bitwarden integration.