[FormAnalyzer] Fix paperlesspost.com login form #711

dbajpeyi · 2024-11-28T13:34:42Z

Reviewer: @shakyShane @GioSensation
Asana: https://app.asana.com/0/1200930669568058/1208734403743969/f

Description

paperlesspost.com login form is treated by autofill as signup because the button element with text "Do you have an account? Sign Up" get's marked as "likely a submit", causing the score to skyrocket to +20:

The problem is that this condition of el.type is always 'submit', unless type was explicitly set to something else.

// If there is another element marked as submit and this is not, flip back to false
if (el.type !== 'submit' && el !== submit) {
    likelyASubmit = false;
}

Checking el.type defaults to 'submit' when nothing is set on the button (as buttons are submit by default), although in think in this case we want to be explicitly checking the submit attribute with getAttrinute('type') instead, to know that a button was explicitly set using submit.

Form signals (before)

Form signals (after)

Steps to test

Go to paperlesspost.com
Try logging in
(Before fix) you see email protection,
(After fix) you should see login autofill.

dbajpeyi · 2024-11-28T14:03:00Z

src/Form/FormAnalyzer.js

@@ -272,7 +272,7 @@ class FormAnalyzer {
            if (likelyASubmit) {
                this.form.querySelectorAll('input[type=submit], button[type=submit]').forEach((submit) => {
                    // If there is another element marked as submit and this is not, flip back to false
-                    if (el.type !== 'submit' && el !== submit) {
+                    if (el.getAttribute('type') !== 'submit' && el !== submit) {


I think this is what we want to do here - check if this element if it's explicitly a submit type, although I am not sure.

Lol, this is wild. Nice find.

GioSensation

Great find, thanks!

GioSensation · 2024-12-04T13:13:24Z

src/Form/FormAnalyzer.js

@@ -272,7 +272,7 @@ class FormAnalyzer {
            if (likelyASubmit) {
                this.form.querySelectorAll('input[type=submit], button[type=submit]').forEach((submit) => {
                    // If there is another element marked as submit and this is not, flip back to false
-                    if (el.type !== 'submit' && el !== submit) {
+                    if (el.getAttribute('type') !== 'submit' && el !== submit) {


Lol, this is wild. Nice find.

@muodov

Task/Issue URL: https://app.asana.com/0/1208923931185505/1208923931185505 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.0.0 ## Description Updates Autofill to version [16.0.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.0.0). ### Autofill 16.0.0 release notes ## What's Changed This PR introduces breaking changes for Android/Windows causing save autofill prompt to get triggered in username only fields. * Upgrade to shared eslint config + Adopt Prettier by @muodov in duckduckgo/duckduckgo-autofill#695 * Ignore lint PR in git blame by @muodov in duckduckgo/duckduckgo-autofill#699 * Update password-related json files (2024-11-18) by @daxmobile in duckduckgo/duckduckgo-autofill#706 * [Form] Always scan shadow elements when categorizing the form inputs by @dbajpeyi in duckduckgo/duckduckgo-autofill#703 * Bump ts-to-zod from 3.1.3 to 3.14.0 by @dependabot in duckduckgo/duckduckgo-autofill#710 * [FormAnalyzer] Fix paperlesspost.com login form by @dbajpeyi in duckduckgo/duckduckgo-autofill#711 * [FormAnalyzer] Tweak regex to match forgot password attribute by @dbajpeyi in duckduckgo/duckduckgo-autofill#712 * [Form] Trigger partialSave on username/email only form submit by @dbajpeyi in duckduckgo/duckduckgo-autofill#702 **Full Changelog**: duckduckgo/duckduckgo-autofill@15.1.0...16.0.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: dbajpeyi <[email protected]>

@muodov

Task/Issue URL: https://app.asana.com/0/1208923931185505/1208923931185505 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.0.0 BSK PR: duckduckgo/BrowserServicesKit#1122 ## Description Updates Autofill to version [16.0.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.0.0). ### Autofill 16.0.0 release notes ## What's Changed This PR introduces breaking changes for Android/Windows causing save autofill prompt to get triggered in username only fields. * Upgrade to shared eslint config + Adopt Prettier by @muodov in duckduckgo/duckduckgo-autofill#695 * Ignore lint PR in git blame by @muodov in duckduckgo/duckduckgo-autofill#699 * Update password-related json files (2024-11-18) by @daxmobile in duckduckgo/duckduckgo-autofill#706 * [Form] Always scan shadow elements when categorizing the form inputs by @dbajpeyi in duckduckgo/duckduckgo-autofill#703 * Bump ts-to-zod from 3.1.3 to 3.14.0 by @dependabot in duckduckgo/duckduckgo-autofill#710 * [FormAnalyzer] Fix paperlesspost.com login form by @dbajpeyi in duckduckgo/duckduckgo-autofill#711 * [FormAnalyzer] Tweak regex to match forgot password attribute by @dbajpeyi in duckduckgo/duckduckgo-autofill#712 * [Form] Trigger partialSave on username/email only form submit by @dbajpeyi in duckduckgo/duckduckgo-autofill#702 **Full Changelog**: duckduckgo/duckduckgo-autofill@15.1.0...16.0.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). --------- Co-authored-by: dbajpeyi <[email protected]> Co-authored-by: Graeme Arthur <[email protected]>

@muodov

Task/Issue URL: https://app.asana.com/0/1208923931185505/1208923931185505 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.0.0 BSK PR: duckduckgo/BrowserServicesKit#1122 ## Description Updates Autofill to version [16.0.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.0.0). ### Autofill 16.0.0 release notes ## What's Changed This PR introduces breaking changes for Android/Windows causing save autofill prompt to get triggered in username only fields. * Upgrade to shared eslint config + Adopt Prettier by @muodov in duckduckgo/duckduckgo-autofill#695 * Ignore lint PR in git blame by @muodov in duckduckgo/duckduckgo-autofill#699 * Update password-related json files (2024-11-18) by @daxmobile in duckduckgo/duckduckgo-autofill#706 * [Form] Always scan shadow elements when categorizing the form inputs by @dbajpeyi in duckduckgo/duckduckgo-autofill#703 * Bump ts-to-zod from 3.1.3 to 3.14.0 by @dependabot in duckduckgo/duckduckgo-autofill#710 * [FormAnalyzer] Fix paperlesspost.com login form by @dbajpeyi in duckduckgo/duckduckgo-autofill#711 * [FormAnalyzer] Tweak regex to match forgot password attribute by @dbajpeyi in duckduckgo/duckduckgo-autofill#712 * [Form] Trigger partialSave on username/email only form submit by @dbajpeyi in duckduckgo/duckduckgo-autofill#702 **Full Changelog**: duckduckgo/duckduckgo-autofill@15.1.0...16.0.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). --------- Co-authored-by: dbajpeyi <[email protected]> Co-authored-by: Graeme Arthur <[email protected]>

dbajpeyi added 2 commits November 28, 2024 12:00

fix: check if texts are wrapped in buttons

5d30d7e

fix: check if submit attribute was explicitly

edb57e3

dbajpeyi changed the title ~~Dbajpeyi/fix/paperlesspost.com~~ [FornAnalyzer] Fix paperlesspost.com login form Nov 28, 2024

dbajpeyi changed the title ~~[FornAnalyzer] Fix paperlesspost.com login form~~ [FormAnalyzer] Fix paperlesspost.com login form Nov 28, 2024

dbajpeyi marked this pull request as ready for review November 28, 2024 13:54

revert: don't check for parent external link

c9ebdb7

dbajpeyi requested a review from shakyShane November 28, 2024 13:56

dbajpeyi commented Nov 28, 2024

View reviewed changes

Merge branch 'main' into dbajpeyi/fix/paperlesspost.com

3104f3a

GioSensation approved these changes Dec 4, 2024

View reviewed changes

dbajpeyi merged commit 7290361 into main Dec 4, 2024
1 check passed

dbajpeyi deleted the dbajpeyi/fix/paperlesspost.com branch December 4, 2024 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FormAnalyzer] Fix paperlesspost.com login form #711

[FormAnalyzer] Fix paperlesspost.com login form #711

dbajpeyi commented Nov 28, 2024 •

edited

Loading

dbajpeyi Nov 28, 2024 •

edited

Loading

GioSensation Dec 4, 2024

GioSensation left a comment

GioSensation Dec 4, 2024

[FormAnalyzer] Fix paperlesspost.com login form #711

[FormAnalyzer] Fix paperlesspost.com login form #711

Conversation

dbajpeyi commented Nov 28, 2024 • edited Loading

Description

Steps to test

dbajpeyi Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

GioSensation Dec 4, 2024

Choose a reason for hiding this comment

GioSensation left a comment

Choose a reason for hiding this comment

GioSensation Dec 4, 2024

Choose a reason for hiding this comment

dbajpeyi commented Nov 28, 2024 •

edited

Loading

dbajpeyi Nov 28, 2024 •

edited

Loading