Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceInterface] Call closeautofillparent only after openManage calls #718

Merged
merged 1 commit into from
Dec 13, 2024
+39 −29
Merged

[DeviceInterface] Call closeautofillparent only after openManage calls #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions dist/autofill-debug.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions dist/autofill.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions src/UI/controllers/HTMLTooltipUIController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,23 +328,25 @@ export class HTMLTooltipUIController extends UIController {

/**
* Called when clicking on the Manage… button in the html tooltip
*
* @param {SupportedMainTypes} type
* @returns {*}
* @private
*/
_onManage(type) {
this.removeTooltip();
switch (type) {
case 'credentials':
return this._options.device.openManagePasswords();
this._options.device.openManagePasswords();
break;
case 'creditCards':
return this._options.device.openManageCreditCards();
this._options.device.openManageCreditCards();
break;
case 'identities':
return this._options.device.openManageIdentities();
this._options.device.openManageIdentities();
break;
default:
// noop
}
this.removeTooltip();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to affect MacOS - would like to avoid multiple/split implementation between platforms unless really necessary (doesn't seem like it).

}

_onIncontextSignupDismissed({ hasOtherOptions }) {
Expand Down
14 changes: 8 additions & 6 deletions swift-package/Resources/assets/autofill-debug.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions swift-package/Resources/assets/autofill.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading