[Matching] Update regex to match for 'confirm password' #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajpeyi
changed the title
dbajpeyi
changed the title
GioSensation
requested changes
Dec 19, 2024
dbajpeyi
force-pushed
the
dbajpeyi/bug/deltamath.com
branch
from
46d343d to
e062675
Compare
dbajpeyi
force-pushed
the
dbajpeyi/bug/deltamath.com
branch
from
e062675 to
0fcb65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/1205996472158114/1208965688770983/f
Description
"Confirm password" doesn't match the
newPasswordregex test, causing the field type to be password.current. This PR updates the regex, no regression is obvious.Steps to test
Can be tested on
deltamath.com's reset password flow, you need an account (a teacher account is free to create), to trigger the forgot password link.