[CredentialsImport] Call credentials flow call first, and then close parent #723
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajpeyi
changed the title
GioSensation
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Seems acceptable on macOS.
- Are there other scenarios that may have regressed on Windows? Have you checked all those
CloseAutofillParentCalls? - Can you check on macOS if there are other scenarios where we switched the call order and whether there is an impact on UX? Like the Manage… button?
dbajpeyi
force-pushed
the
dbajpeyi/bug/credentials-import-race-condition
branch
from
8f8c68b to
05651de
Compare
|
dbajpeyi
force-pushed
the
dbajpeyi/bug/credentials-import-race-condition
branch
from
05651de to
b4c96d2
Compare
This was referenced Dec 18, 2024
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Dec 18, 2024
Task/Issue URL: https://app.asana.com/0/1209009001482464/1209009001482464 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.1.0 ## Description Updates Autofill to version [16.1.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/16.1.0). ### Autofill 16.1.0 release notes ## What's Changed * [DeviceInterface] Call closeautofillparent only after openManage calls by @dbajpeyi in duckduckgo/duckduckgo-autofill#718 * [CredentialsImport] Call credentials flow call first, and then close parent by @dbajpeyi in duckduckgo/duckduckgo-autofill#723 * [FeatureToggle] Add new autofill config for partial save trigger by @dbajpeyi in duckduckgo/duckduckgo-autofill#724 **Full Changelog**: duckduckgo/duckduckgo-autofill@16.0.0...16.1.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: dbajpeyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/1203822806345703/1208958786488368/f
Description
On windows
IWebViewdisposes aftercloseAutofillParentmore efficiently (since https://github.com/duckduckgo/windows-browser/pull/2658/files#diff-e9708afe1dc71c217b0379bc7531fd02309a7ce40e69ce7e60e3bed7edde1160) now causingstartCredentialsImportFlowcall to be late. This causes the native import flow UI to not open anymore.This PR changes the sequence of
closeAutofillParentandstartCredentialsImportFlowcalls. Note that this will also affect MacOS, it does affect MAC a little bit as the parent closes a bit later than the import prompt. I think it's not bad enough, and doesn't call for multiple implementationsTests
(Before)
close-parent-before-mac.mov
(After, regression in UX?)
close-parent-after-mac.mov
close-parent-windows.mov