[FormAnalyzer] Don't flip scores on buttons with specific text #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajpeyi
force-pushed
the
dbajpeyi/fix/wetransfer.com
branch
from
e4e73dc to
6ef0308
Compare
dbajpeyi
commented
Dec 20, 2024
| * @param {string} text | ||
| * @returns {boolean} | ||
| */ | ||
| shouldFlipScoreForButtonText(text) { |
There was a problem hiding this comment.
I wanted to re-use this also for external link part, but that's a little bit different in terms of score strength. keeping it
dbajpeyi
changed the title
dbajpeyi
force-pushed
the
dbajpeyi/fix/wetransfer.com
branch
from
c66b884 to
5d2c6ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/1200930669568058/1209022781094891/f
Description
Seems like we end up flipping the score on buttons with "Forgot password", causing to add signup score. This PR adds that check, and also includes test for "Stay signed in" because those are part of login forms too.
Steps to test
https://auth.wetransfer.com/login, https://freshdirect.com and revolut business break because of this (login becomes signup/generate password offered).
Score before:
Score after:
