Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle debug flags sent from C-S-S #2138

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Handle debug flags sent from C-S-S #2138

merged 3 commits into from
Jul 27, 2023

Conversation

muodov
Copy link
Member

@muodov muodov commented Jul 24, 2023

Reviewer: @shakyShane
CC: @jonathanKingston
Depends on: duckduckgo/content-scope-scripts#648

Description:

MVP infra for generic debug flags for C-S-S features. This is not yet a full Messaging implementation, which should come in later stages of the project.

Steps to test this PR:

  1. Add a log to the breakage report, or set up a proxy to see the breakage pixel URL
  2. Build the extension with C-S-S changes from Breakage debug flags content-scope-scripts#648
  3. Open any page with enabled protections (e.g. example.com)
  4. Trigger the protections:
  • navigator.hardwareConcurrency
  • (await navigator.getBattery()).charging (Chromium only)
  1. Send a breakage report form
  2. Verify that debugFlags parameter is present in the pixel URL

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@muodov muodov added the WIP label Jul 24, 2023
@muodov muodov requested a review from sammacbeth July 27, 2023 10:39
@muodov muodov merged commit bb0e54a into main Jul 27, 2023
17 checks passed
@muodov muodov deleted the max/debug-flags branch July 28, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants