Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Prettier #2797

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Introduce Prettier #2797

merged 7 commits into from
Nov 6, 2024

Conversation

muodov
Copy link
Member

@muodov muodov commented Nov 4, 2024

Reviewer: @sammacbeth

Description:

https://app.asana.com/0/1201807839809179/1208561434802767/f
This PR:

  • Introduces Prettier
  • applies it to the whole codebase
    Recommend to review commit-by-commit because most of the diff is formatting auto-fix

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

packages/ddg2dnr/test/cookies.js Dismissed Show dismissed Hide dismissed
packages/ddg2dnr/test/cookies.js Dismissed Show dismissed Hide dismissed
packages/ddg2dnr/test/cookies.js Fixed Show fixed Hide fixed
packages/ddg2dnr/test/cookies.js Fixed Show fixed Hide fixed
@muodov muodov marked this pull request as ready for review November 4, 2024 16:11
@muodov
Copy link
Member Author

muodov commented Nov 4, 2024

@sammacbeth I'm assuming the codeQL warnings are safe to ignore because they apply to the test files, right?

packages/ddg2dnr/test/cookies.js Dismissed Show dismissed Hide dismissed
packages/ddg2dnr/test/cookies.js Dismissed Show dismissed Hide dismissed
packages/ddg2dnr/test/cookies.js Dismissed Show dismissed Hide dismissed
@muodov muodov changed the title Fix lint issues (prettier) Introduce Prettier Nov 5, 2024
@muodov muodov marked this pull request as ready for review November 5, 2024 12:54
Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the full 16k lines of diff, so just assuming that prettier did everything correctly :/

@muodov muodov merged commit 555cfe3 into main Nov 6, 2024
24 checks passed
@muodov muodov deleted the prettier branch November 6, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants