Remove noise pixels and limit the counter parameter to 5

duckduckgo · Dec 20, 2024 · 0a694ec · 0a694ec
1 parent 82ee613
commit 0a694ec
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/DuckDuckGo/AppLifecycle/AppStateTransitions.swift b/DuckDuckGo/AppLifecycle/AppStateTransitions.swift
@@ -102,9 +102,6 @@ extension Background {
 extension DoubleBackground {
 
     func apply(event: AppEvent) -> any AppState {
-        // report event so we know what events can be called at this moment, but do not let SM be stuck in this state just not to be flooded with these events
-        _ = handleUnexpectedEvent(event)
-
         switch event {
         case .activating(let application):
             return Active(application: application)
@@ -123,9 +120,6 @@ extension DoubleBackground {
 extension InactiveBackground {
 
     func apply(event: AppEvent) -> any AppState {
-        // report event so we know what events can be called at this moment, but do not let SM be stuck in this state just not to be flooded with these events
-        _ = handleUnexpectedEvent(event)
-
         switch event {
         case .activating(let application):
             return Active(application: application)

diff --git a/DuckDuckGo/AppLifecycle/AppStates/Background.swift b/DuckDuckGo/AppLifecycle/AppStates/Background.swift
@@ -47,10 +47,13 @@ struct DoubleBackground: AppState {
 
         var parameters = [
             PixelParameters.firstBackgroundTimestamp: dateFormatter.string(from: previousDidEnterBackgroundTimestamp),
-            PixelParameters.secondBackgroundTimestamp: dateFormatter.string(from: currentDidEnterBackgroundTimestamp),
-            PixelParameters.numberOfBackgrounds: String(counter)
+            PixelParameters.secondBackgroundTimestamp: dateFormatter.string(from: currentDidEnterBackgroundTimestamp)
         ]
 
+        if counter < 5 {
+            parameters[PixelParameters.numberOfBackgrounds] = String(counter)
+        }
+
         func isValid(timestamp: Date) -> Bool {
             timestamp >= previousDidEnterBackgroundTimestamp && timestamp <= currentDidEnterBackgroundTimestamp
         }