add pixel and only fire / change tabs when the index is different

duckduckgo · Feb 1, 2024 · 103dcd3 · 103dcd3
1 parent cc424da
commit 103dcd3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/Core/PixelEvent.swift b/Core/PixelEvent.swift
@@ -502,6 +502,9 @@ extension Pixel {
         case syncDeleteAccountError
         case syncLoginExistingAccountError
 
+        case swipeTabsUsed
+        case swipeTabsUsedDaily
+
         case bookmarksCleanupFailed
         case bookmarksCleanupAttemptedWhileSyncWasEnabled
         case favoritesCleanupFailed
@@ -995,6 +998,8 @@ extension Pixel.Event {
         case .syncDeleteAccountError: return "m_d_sync_delete_account_error"
         case .syncLoginExistingAccountError: return "m_d_sync_login_existing_account_error"
 
+        case .swipeTabsUsed: return "m_swipe-tabs-used"
+        case .swipeTabsUsedDaily: return "m_swipe-tabs-used-daily"
 
         case .bookmarksCleanupFailed: return "m_d_bookmarks_cleanup_failed"
         case .bookmarksCleanupAttemptedWhileSyncWasEnabled: return "m_d_bookmarks_cleanup_attempted_while_sync_was_enabled"

diff --git a/DuckDuckGo/MainViewController.swift b/DuckDuckGo/MainViewController.swift
@@ -315,7 +315,13 @@ class MainViewController: UIViewController {
         swipeTabsCoordinator = SwipeTabsCoordinator(coordinator: viewCoordinator,
                                                     tabPreviewsSource: previewsSource,
                                                     appSettings: appSettings) { [weak self] in
+
+            guard $0 != self?.tabManager.model.currentIndex else { return }
+
+            DailyPixel.fire(pixel: .swipeTabsUsedDaily)
+            Pixel.fire(pixel: .swipeTabsUsed)
             self?.select(tabAt: $0)
+
         } newTab: { [weak self] in
             self?.newTab()
         } onSwipeStarted: { [weak self] in