Skip to content

Commit

Permalink
Use different explanation copy for new settings
Browse files Browse the repository at this point in the history
  • Loading branch information
ayoy committed Apr 12, 2024
1 parent 4c8bd74 commit 35950d3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo/AboutView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ struct AboutViewVersion: View {
@EnvironmentObject var viewModel: SettingsViewModel

var body: some View {
Section(header: Text("DuckDuckGo for iOS"), footer: Text(UserText.settingsSendCrashReportsDescription)) {
Section(header: Text("DuckDuckGo for iOS"), footer: Text(UserText.settingsSendCrashReportsDescriptionNew)) {
SettingsCellView(label: UserText.settingsVersion,
accesory: .rightDetail(viewModel.state.version))

Expand Down
3 changes: 2 additions & 1 deletion DuckDuckGo/UserText.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,8 @@ But if you *do* want a peek under the hood, you can find more information about
public static let settingsAboutDDG = NSLocalizedString("settings.about.ddg", value: "About DuckDuckGo", comment: "Settings cell for About DDG")
public static let settingsVersion = NSLocalizedString("settings.version", value: "Version", comment: "Settings cell for Version")
public static let settingsSendCrashReports = NSLocalizedString("settings.send.crash.reports", value: "Send Crash Reports", comment: "Settings cell for Send Crash Reports")
public static let settingsSendCrashReportsDescription = NSLocalizedString("settings.send.crash.reports.description", value: "Automatically send crash reports to DuckDuckGo.", comment: "Explanation of Send Crash Reports settings option")
public static let settingsSendCrashReportsDescription = NSLocalizedString("settings.send.crash.reports.description", value: "Automatically send crash reports to DuckDuckGo", comment: "Explanation of Send Crash Reports settings option")
public static let settingsSendCrashReportsDescriptionNew = NSLocalizedString("settings.send.crash.reports.description2", value: "Automatically send crash reports to DuckDuckGo.", comment: "Explanation of Send Crash Reports settings option")

// MARK: Crash Reporting

Expand Down
5 changes: 4 additions & 1 deletion DuckDuckGo/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -1993,7 +1993,10 @@ But if you *do* want a peek under the hood, you can find more information about
"settings.send.crash.reports" = "Send Crash Reports";

/* Explanation of Send Crash Reports settings option */
"settings.send.crash.reports.description" = "Automatically send crash reports to DuckDuckGo.";
"settings.send.crash.reports.description" = "Automatically send crash reports to DuckDuckGo";

/* Explanation of Send Crash Reports settings option */
"settings.send.crash.reports.description2" = "Automatically send crash reports to DuckDuckGo.";

/* Settings screen cell text for setting address bar position */
"settings.set.your.address.bar.position" = "Set Your Address Bar Position";
Expand Down

0 comments on commit 35950d3

Please sign in to comment.